Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252783: Remove the css Selector and ShapeConverter constructors #512

Closed
wants to merge 1 commit into from

Conversation

aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented May 21, 2021

The javafx.css.Selector and javafx.css.converter.ShapeConverter constructors were deprecated for removal in openjfx16.
This PR removes these constructors (targeted for openjfx17).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252783: Remove the css Selector and ShapeConverter constructors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/512/head:pull/512
$ git checkout pull/512

Update a local copy of the PR:
$ git checkout pull/512
$ git pull https://git.openjdk.java.net/jfx pull/512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 512

View PR using the GUI difftool:
$ git pr show -t 512

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/512.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@aghaisas
Copy link
Collaborator Author

/csr

@openjdk openjdk bot added rfr Ready for review csr Need approved CSR to integrate pull request labels May 21, 2021
@openjdk
Copy link

openjdk bot commented May 21, 2021

@aghaisas has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@aghaisas please create a CSR request for issue JDK-8252783. This pull request cannot be integrated until the CSR request is approved.

@mlbridge
Copy link

mlbridge bot commented May 21, 2021

Webrevs

@kevinrushforth kevinrushforth self-requested a review May 21, 2021 12:32
@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented May 21, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@openjdk openjdk bot removed the csr Need approved CSR to integrate pull request label May 26, 2021
@openjdk
Copy link

openjdk bot commented May 26, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252783: Remove the css Selector and ShapeConverter constructors

Reviewed-by: kcr, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 329013b: 8267621: Mark HonorDeveloperSettingsTest as unstable on Linux
  • 24ffe35: 8265210: TreeCell: cell editing state not updated on cell re-use
  • 9507ea4: 8264140: Add -Djava.security.manager=allow to JavaFX tests calling setSecurityManager
  • 2fd5092: 8263761: Update boot JDK to 16.0.1
  • aebac07: 8210199: [linux / macOS] fileChooser can't handle emojis
  • 240d28f: 8264127: ListCell editing status is true, when index changes while editing
  • 5843910: 8267392: ENTER key press on editable TableView throws NPE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 26, 2021
@aghaisas
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this May 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels May 26, 2021
@openjdk
Copy link

openjdk bot commented May 26, 2021

@aghaisas Since your change was applied there have been 7 commits pushed to the master branch:

  • 329013b: 8267621: Mark HonorDeveloperSettingsTest as unstable on Linux
  • 24ffe35: 8265210: TreeCell: cell editing state not updated on cell re-use
  • 9507ea4: 8264140: Add -Djava.security.manager=allow to JavaFX tests calling setSecurityManager
  • 2fd5092: 8263761: Update boot JDK to 16.0.1
  • aebac07: 8210199: [linux / macOS] fileChooser can't handle emojis
  • 240d28f: 8264127: ListCell editing status is true, when index changes while editing
  • 5843910: 8267392: ENTER key press on editable TableView throws NPE

Your commit was automatically rebased without conflicts.

Pushed as commit a645b5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aghaisas aghaisas deleted the remove_constructors branch July 19, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants