New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252783: Remove the css Selector and ShapeConverter constructors #512
Conversation
👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into |
/csr |
@aghaisas has indicated that a compatibility and specification (CSR) request is needed for this pull request. |
/reviewers 2 |
@kevinrushforth |
@aghaisas This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@aghaisas Since your change was applied there have been 7 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a645b5a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The javafx.css.Selector and javafx.css.converter.ShapeConverter constructors were deprecated for removal in openjfx16.
This PR removes these constructors (targeted for openjfx17).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/512/head:pull/512
$ git checkout pull/512
Update a local copy of the PR:
$ git checkout pull/512
$ git pull https://git.openjdk.java.net/jfx pull/512/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 512
View PR using the GUI difftool:
$ git pr show -t 512
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/512.diff