Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267621: Mark HonorDeveloperSettingsTest as unstable on Linux #517

Closed
wants to merge 2 commits into from

Conversation

@arapte
Copy link
Member

@arapte arapte commented May 24, 2021

The test HonorDeveloperSettingsTest.testOpacityWithManuallyChangedValueAndInlineStyleIsSetToInlineStyle is failing intermittently only on GHA build on Linux platform. see: JDK-8267425

A fix proposed at #509 is a potential fix which adds cleanup of test. But we do not know the root cause of this failure.
Identifying the root cause may take longer which we might push that to next test sprint and the test failure results in failing the Github checks on PR. So we need to mark this test as unstable.
As of now the test fails only on Linux so we will mark it unstable only for Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267621: Mark HonorDeveloperSettingsTest as unstable on Linux

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/517/head:pull/517
$ git checkout pull/517

Update a local copy of the PR:
$ git checkout pull/517
$ git pull https://git.openjdk.java.net/jfx pull/517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 517

View PR using the GUI difftool:
$ git pr show -t 517

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/517.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 24, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 24, 2021

Webrevs

Loading

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 24, 2021

Since the NPE is happening in the setUp method, which is annotated with @Before and runs before the test itself, it seems unlikely that marking just a single test method as unstable is sufficient.

Loading

@arapte
Copy link
Member Author

@arapte arapte commented May 24, 2021

True, it is possible that some other test may fail similarly. Shall we mark all tests as unstable ?

Loading

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 24, 2021

I would mark the whole class as unstable. You can do this by adding a static method annotated with @BeforeClass.

Loading

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 24, 2021

Or you can add it to the existing per-test setUp method.

Loading

@arapte
Copy link
Member Author

@arapte arapte commented May 24, 2021

Both ways are generating same report, But @BeforeClass looks better to me.
Shall I change the JBS summary too ? as Mark HonorDeveloperSettingsTest as unstable on Linux

Loading

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 24, 2021

Yes, please update the JBS title and PR title.

Loading

@arapte arapte changed the title 8267621: Mark HonorDeveloperSettingsTest.testOpacityWithManuallyChangedValueAndInlineStyleIsSetToInlineStyle as unstable 8267621: Mark HonorDeveloperSettingsTest as unstable on Linux May 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 24, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267621: Mark HonorDeveloperSettingsTest as unstable on Linux

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 24ffe35: 8265210: TreeCell: cell editing state not updated on cell re-use
  • 9507ea4: 8264140: Add -Djava.security.manager=allow to JavaFX tests calling setSecurityManager
  • 2fd5092: 8263761: Update boot JDK to 16.0.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 24, 2021
@arapte
Copy link
Member Author

@arapte arapte commented May 24, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 24, 2021

@arapte Since your change was applied there have been 3 commits pushed to the master branch:

  • 24ffe35: 8265210: TreeCell: cell editing state not updated on cell re-use
  • 9507ea4: 8264140: Add -Djava.security.manager=allow to JavaFX tests calling setSecurityManager
  • 2fd5092: 8263761: Update boot JDK to 16.0.1

Your commit was automatically rebased without conflicts.

Pushed as commit 329013b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants