Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269026: PasswordField doesn't render bullet character on Android #537

Closed
wants to merge 2 commits into from

Conversation

@jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Jun 18, 2021

This PR modifies the PasswordField's bullet character used on Android, as the current unicode code is not supported for most fonts, including Roboto.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269026: PasswordField doesn't render bullet character on Android

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/537/head:pull/537
$ git checkout pull/537

Update a local copy of the PR:
$ git checkout pull/537
$ git pull https://git.openjdk.java.net/jfx pull/537/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 537

View PR using the GUI difftool:
$ git pr show -t 537

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/537.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

if (getSkinnable() instanceof PasswordField) {
return String.valueOf(BULLET).repeat(txt.length());
} else {
return txt;
Copy link
Member

@kevinrushforth kevinrushforth Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this call return super.maskText(txt); in case the implementation of the superclass method ever changes? Either is OK with me.

Copy link
Collaborator Author

@jperedadnr jperedadnr Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense, even if it causes a double check of getSkinnable(), but that seems negligible. I'll update it

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269026: PasswordField doesn't render bullet character on Android

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 18, 2021
@openjdk openjdk bot removed the ready label Jun 18, 2021
@openjdk openjdk bot added the ready label Jun 18, 2021
@jperedadnr
Copy link
Collaborator Author

@jperedadnr jperedadnr commented Jun 18, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

Going to push as commit 13cffba.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@jperedadnr Pushed as commit 13cffba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants