Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269147: Update GStreamer to version 1.18.4 #541

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Jun 24, 2021

  • GStreamer updated to 1.18.4.
  • Tested on all platforms with all formats.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/541/head:pull/541
$ git checkout pull/541

Update a local copy of the PR:
$ git checkout pull/541
$ git pull https://git.openjdk.java.net/jfx pull/541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 541

View PR using the GUI difftool:
$ git pr show -t 541

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/541.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jun 24, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2021

Webrevs

@johanvos
Copy link
Collaborator

Those changes look reasonable. It seems that mainly windows is impacted. @tiainen can you double-check the static windows builds are ok with those changes?

@johanvos johanvos requested a review from tiainen June 24, 2021 08:21
@kevinrushforth kevinrushforth self-requested a review June 24, 2021 11:19
@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. I tested it on all three platforms. No problems.

@tiainen can be the second reviewer on this.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've also tested the changes on our build infrastructure and it all worked fine.

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269147: Update GStreamer to version 1.18.4

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • a1be1d5: 8267418: IntelliJ build and test of JavaFX does not work
  • b0d1586: 8266224: GitHub actions: use gcc 10.3 on Linux
  • 12fb4da: 8269259: Remove obsolete apps, tests, and scripts
  • 50ed890: 8269424: Some SuppressWarnings annotations can be more localized
  • 98e5166: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync
  • c4cc998: 8196065: ListChangeListener getRemoved() returns items that were not removed.
  • 78179be: 8267554: Support loading stylesheets from data-URIs
  • 3fd4c97: 8234920: Add SpotLight to the selection of 3D light types
  • 063bfe8: 8264137: Suppress deprecation and removal warnings of internal methods
  • 8e11b94: 8268915: WebKit build fails with Xcode 12.5
  • ... and 2 more: https://git.openjdk.java.net/jfx/compare/13cffbaad4068177d2d3239fa297302c3f94c217...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jun 30, 2021
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

Going to push as commit 098c0f3.
Since your change was applied there have been 12 commits pushed to the master branch:

  • a1be1d5: 8267418: IntelliJ build and test of JavaFX does not work
  • b0d1586: 8266224: GitHub actions: use gcc 10.3 on Linux
  • 12fb4da: 8269259: Remove obsolete apps, tests, and scripts
  • 50ed890: 8269424: Some SuppressWarnings annotations can be more localized
  • 98e5166: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync
  • c4cc998: 8196065: ListChangeListener getRemoved() returns items that were not removed.
  • 78179be: 8267554: Support loading stylesheets from data-URIs
  • 3fd4c97: 8234920: Add SpotLight to the selection of 3D light types
  • 063bfe8: 8264137: Suppress deprecation and removal warnings of internal methods
  • 8e11b94: 8268915: WebKit build fails with Xcode 12.5
  • ... and 2 more: https://git.openjdk.java.net/jfx/compare/13cffbaad4068177d2d3239fa297302c3f94c217...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@sashamatveev Pushed as commit 098c0f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants