New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269147: Update GStreamer to version 1.18.4 #541
Conversation
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
Those changes look reasonable. It seems that mainly windows is impacted. @tiainen can you double-check the static windows builds are ok with those changes? |
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good. I tested it on all three platforms. No problems.
@tiainen can be the second reviewer on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've also tested the changes on our build infrastructure and it all worked fine.
@sashamatveev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 098c0f3.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit 098c0f3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/541/head:pull/541
$ git checkout pull/541
Update a local copy of the PR:
$ git checkout pull/541
$ git pull https://git.openjdk.java.net/jfx pull/541/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 541
View PR using the GUI difftool:
$ git pr show -t 541
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/541.diff