Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269424: Some SuppressWarnings annotations can be more localized #546

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 26, 2021

This is a follow-on fix to JDK-8264139, which added @SuppressWarning annotations to usages of deprecated security manager methods. @wangweij noticed that there was one pattern where the automated tool added the warning at a higher level than was needed. This fix moves the annotation down to be more localized in the two places that were affected.

/contributor add weijun


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269424: Some SuppressWarnings annotations can be more localized

Reviewers

Contributors

  • Weijun Wang <weijun@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/546/head:pull/546
$ git checkout pull/546

Update a local copy of the PR:
$ git checkout pull/546
$ git pull https://git.openjdk.java.net/jfx pull/546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 546

View PR using the GUI difftool:
$ git pr show -t 546

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/546.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 26, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 26, 2021

@kevinrushforth
Contributor Weijun Wang <weijun@openjdk.org> successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 26, 2021

Webrevs

@kevinrushforth kevinrushforth requested a review from aghaisas Jun 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 27, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269424: Some SuppressWarnings annotations can be more localized

Co-authored-by: Weijun Wang <weijun@openjdk.org>
Reviewed-by: aghaisas, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 27, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jun 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

Going to push as commit 50ed890.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 98e5166: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync
  • c4cc998: 8196065: ListChangeListener getRemoved() returns items that were not removed.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@kevinrushforth Pushed as commit 50ed890.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8269424-sm-removal branch Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants