Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync #549

Closed
wants to merge 1 commit into from

Conversation

Maran23
Copy link
Member

@Maran23 Maran23 commented Jun 28, 2021

This PR fixes the issue identified and discussed in PR #506 which will make the gradle sync in IntelliJ fail because of the failing dependency verification for source files.

Gradle provides a way to skip the verification of source files, documented here:
https://docs.gradle.org/current/userguide/dependency_verification.html#sec:skipping-javadocs

Also the README.txt file is adjusted to include the instructions neccessary when updating the verification-metadata.xml file.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/549/head:pull/549
$ git checkout pull/549

Update a local copy of the PR:
$ git checkout pull/549
$ git pull https://git.openjdk.java.net/jfx pull/549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 549

View PR using the GUI difftool:
$ git pr show -t 549

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/549.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2021

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jun 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2021

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@nlisker nlisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Eclipse and it resolves the error of not finding the JUnit source jar file during dependency verification. Eclipse Buildship is happy now.

@openjdk
Copy link

openjdk bot commented Jun 29, 2021

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

Reviewed-by: kcr, nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @nlisker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Jun 29, 2021
@Maran23
Copy link
Member Author

Maran23 commented Jun 29, 2021

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Jun 29, 2021
@openjdk
Copy link

openjdk bot commented Jun 29, 2021

@Maran23
Your change (at version 3620e0f) is now ready to be sponsored by a Committer.

@nlisker
Copy link
Collaborator

nlisker commented Jun 29, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 29, 2021

Going to push as commit 98e5166.

@openjdk openjdk bot closed this Jun 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Jun 29, 2021
@openjdk
Copy link

openjdk bot commented Jun 29, 2021

@nlisker @Maran23 Pushed as commit 98e5166.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Maran23 Maran23 deleted the JDK-8269244-test branch June 30, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants