Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc #552

Closed
wants to merge 2 commits into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Jun 29, 2021

Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of cycle is reached regardless if it is repeating or not.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/552/head:pull/552
$ git checkout pull/552

Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.java.net/jfx pull/552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 552

View PR using the GUI difftool:
$ git pr show -t 552

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/552.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 29, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 29, 2021

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 29, 2021

This looks like a good fix, but should have a CSR, since it changes the specification.

/csr

@kevinrushforth kevinrushforth self-requested a review Jun 29, 2021
@openjdk openjdk bot added the csr label Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@sashamatveev please create a CSR request for issue JDK-8268683. This pull request cannot be integrated until the CSR request is approved.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good with one suggested change.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@openjdk openjdk bot removed the csr label Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 098c0f3: 8269147: Update GStreamer to version 1.18.4
  • a1be1d5: 8267418: IntelliJ build and test of JavaFX does not work
  • b0d1586: 8266224: GitHub actions: use gcc 10.3 on Linux
  • 12fb4da: 8269259: Remove obsolete apps, tests, and scripts
  • 50ed890: 8269424: Some SuppressWarnings annotations can be more localized
  • 98e5166: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 30, 2021
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Jun 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

Going to push as commit cfa60ff.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 098c0f3: 8269147: Update GStreamer to version 1.18.4
  • a1be1d5: 8267418: IntelliJ build and test of JavaFX does not work
  • b0d1586: 8266224: GitHub actions: use gcc 10.3 on Linux
  • 12fb4da: 8269259: Remove obsolete apps, tests, and scripts
  • 50ed890: 8269424: Some SuppressWarnings annotations can be more localized
  • 98e5166: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@sashamatveev Pushed as commit cfa60ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants