New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc #552
Conversation
|
Webrevs
|
This looks like a good fix, but should have a CSR, since it changes the specification. /csr |
@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with one suggested change.
modules/javafx.media/src/main/java/javafx/scene/media/MediaPlayer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@sashamatveev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Going to push as commit cfa60ff.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit cfa60ff. |
Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of cycle is reached regardless if it is repeating or not.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/552/head:pull/552
$ git checkout pull/552
Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.java.net/jfx pull/552/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 552
View PR using the GUI difftool:
$ git pr show -t 552
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/552.diff