Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266224: GitHub actions: use gcc 10.3 on Linux #555

Closed
wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Jun 29, 2021

install latest version of gcc/g++ (older specific versions are not available anymore)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/555/head:pull/555
$ git checkout pull/555

Update a local copy of the PR:
$ git checkout pull/555
$ git pull https://git.openjdk.java.net/jfx pull/555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 555

View PR using the GUI difftool:
$ git pr show -t 555

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/555.diff

install latest version of gcc/g++ (older specific versions are not available anymore)
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 29, 2021

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 29, 2021
@johanvos johanvos requested a review from kevinrushforth Jun 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 29, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good, thanks for taking care of this. I note that JDK-8266224 was already filed for this. I just assigned it to you. Perhaps you could change the title of this PR to use that bug ID instead? (and close the one you just filed as a duplicate).

@johanvos johanvos changed the title 8269601: Increase gcc-10 version for github workflow 8266224: GitHub actions: use gcc 10.3 on Linux Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266224: GitHub actions: use gcc 10.3 on Linux

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 12fb4da: 8269259: Remove obsolete apps, tests, and scripts
  • 50ed890: 8269424: Some SuppressWarnings annotations can be more localized
  • 98e5166: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync
  • c4cc998: 8196065: ListChangeListener getRemoved() returns items that were not removed.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 29, 2021
@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Jun 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

Going to push as commit b0d1586.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 12fb4da: 8269259: Remove obsolete apps, tests, and scripts
  • 50ed890: 8269424: Some SuppressWarnings annotations can be more localized
  • 98e5166: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync
  • c4cc998: 8196065: ListChangeListener getRemoved() returns items that were not removed.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@johanvos Pushed as commit b0d1586.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants