New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269131: Update libxml2 to version 2.9.12 #562
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
Webrevs
|
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good except for the expansion of tags in Makefile.am
(we don't want to expand tabs in Makefiles). I recommend re-copying Makefile.am
from the original sources of libxml 2.9.12. I left a couple questions on the new instructions in UPDATING.txt
as well.
I did a build / test on all 3 platforms. No issues observed.
modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/Makefile.am
Outdated
Show resolved
Hide resolved
modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt
Outdated
Show resolved
Hide resolved
modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt
Outdated
Show resolved
Hide resolved
modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed to work on linux, win, mac (x86_64)
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 52c076c.
Your commit was automatically rebased without conflicts. |
We currently use libxml2 version 2.9.10. It should be updated to latest stable release, which is version 2.9.12.
The steps to update libxml are documented in UPDATING.txt.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/562/head:pull/562
$ git checkout pull/562
Update a local copy of the PR:
$ git checkout pull/562
$ git pull https://git.openjdk.java.net/jfx pull/562/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 562
View PR using the GUI difftool:
$ git pr show -t 562
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/562.diff