Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266743: Crash on macOS 10.11 due to ignored @available 10.12 check #566

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 6, 2021

This fix restores the minimum macOS version needed to run JavaFX on x64 platforms to 10.10.

The fix for JDK-8265031 bumped the minimum version for macOS on aarch64 to 11.0 and on x64 to 10.12. The change on aarch64 was necessary, since that is the minimum version that will run on Apple Silicon. The change on x64 was not necessary, but was done to match JDK 17. In connection with the fix for JDK-8263169, this causes a crash on older macOS systems running 10.10 or 10.11. The long term solution is to detect and throw an exception at startup if the version of macOS is below the minimum, but for JavaFX 17 it was felt that restoring the minimum of macOS 10.10 for x64 platforms was safer.

See the discussion in JBS for more information.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/566/head:pull/566
$ git checkout pull/566

Update a local copy of the PR:
$ git checkout pull/566
$ git pull https://git.openjdk.java.net/jfx pull/566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 566

View PR using the GUI difftool:
$ git pr show -t 566

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/566.diff

Revert minimum version of macOS for x64 platforms to 10.10
@kevinrushforth kevinrushforth requested a review from johanvos Jul 6, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 6, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 6, 2021

Webrevs

Loading

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 6, 2021

I filed two follow-on bugs that are targeted for JavaFX 18:

  1. JDK-8269967: JavaFX should fail fast on macOS below minimum version
  2. JDK-8269968: [REDO] Bump minimum version of macOS for x64 to 10.12

Loading

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 6, 2021

You can ignore the last pair of commits. The first is a "WIP" changes for the eventual fail-fast version detection, and the second reverts the first.

The only change being proposed for this PR is to change the minimum version of macOS for x64 from "10.12" to `"10.10" (that is, back to what it was in JavaFX 16 and earlier releases).

Loading

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 7, 2021

There were failing macOS pre-submit tests. It looks like some sort of intermittent test issue, and in any case is unrelated to this change since the initial commit, with 100% identical content passed. However, I pushed a dummy commit to rerun the tests to remove any question.

Loading

@kevinrushforth kevinrushforth changed the title 8266743: crash on macOS 10.11 due to ignored check on 10.12 8266743: Crash on macOS 10.11 due to ignored @available 10.12 check Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266743: Crash on macOS 10.11 due to ignored @available 10.12 check

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 52c076c: 8269131: Update libxml2 to version 2.9.12

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 7, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 7, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

Going to push as commit 6fe427f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 52c076c: 8269131: Update libxml2 to version 2.9.12

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 7, 2021
@openjdk openjdk bot added integrated and removed ready labels Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@kevinrushforth Pushed as commit 6fe427f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Jul 7, 2021
@kevinrushforth kevinrushforth deleted the 8266743-macOS-10.10 branch Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants