Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl #57

Closed

Conversation

@jperedadnr
Copy link

jperedadnr commented Nov 30, 2019

In GlassApplication.m for iOS, the method
Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl has signature (Ljava/lang/Object;)V, however in IosApplication.java, _leaveNestedEventLoopImpl() signature doesn't match that.

This PR fixes this.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl

Approvers

  • Johan Vos (jvos - Reviewer)
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Nov 30, 2019

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 30, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 30, 2019

Webrevs

@johanvos johanvos self-requested a review Dec 1, 2019
@johanvos

This comment has been minimized.

Copy link
Collaborator

johanvos commented Dec 1, 2019

Looks like a trivial fix to me.
It only impacts the iOS platform.

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 3, 2019

Yes, this looks like a simple, and correct fix. A single reviewer will be sufficient.

@openjdk openjdk bot removed the rfr label Dec 4, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Dec 4, 2019

@jperedadnr This change can now be integrated. The commit message will be:

8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl

Reviewed-by: jvos
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 1c27fbd: 8210955: DOMTest::testEventListenerCascade fails
  • 2d4096a: 8235151: Nonexistent notifyQuit method referred from iOS GlassHelper.m
  • 98035cb: 8211308: Support HTTP/2 in WebView
  • 6892fa1: 8232064: Switch FX build to use JDK 13.0.1 as boot JDK

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@openjdk openjdk bot added the ready label Dec 4, 2019
@jperedadnr

This comment has been minimized.

Copy link
Author

jperedadnr commented Dec 4, 2019

/integrate

@openjdk openjdk bot added the sponsor label Dec 4, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Dec 4, 2019

@jperedadnr
Your change (at version e5fc04a) is now ready to be sponsored by a Committer.

@johanvos

This comment has been minimized.

Copy link
Collaborator

johanvos commented Dec 5, 2019

/sponsor

@openjdk openjdk bot closed this Dec 5, 2019
@openjdk openjdk bot added integrated and removed sponsor ready labels Dec 5, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Dec 5, 2019

@johanvos @jperedadnr The following commits have been pushed to master since your change was applied:

  • 1c27fbd: 8210955: DOMTest::testEventListenerCascade fails
  • 2d4096a: 8235151: Nonexistent notifyQuit method referred from iOS GlassHelper.m
  • 98035cb: 8211308: Support HTTP/2 in WebView
  • 6892fa1: 8232064: Switch FX build to use JDK 13.0.1 as boot JDK

Your commit was automatically rebased without conflicts.

Pushed as commit a68347c.

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Dec 5, 2019

Mailing list message from Johan Vos on openjfx-dev:

Changeset: a68347c
Author: Jose Pereda
Committer: Johan Vos
Date: 2019-12-05 12:23:10 +0000
URL: https://git.openjdk.java.net/jfx/commit/a68347cb

8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl

Reviewed-by: jvos

! modules/javafx.graphics/src/main/java/com/sun/glass/ui/ios/IosApplication.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.