Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269968: [REDO] Bump minimum version of macOS for x64 to 10.12 #570

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 8, 2021

The fix for JDK-8266743 (crash on macOS 10.11) -- was to partially revert JDK-8265031, and lower the minimum macOS version for x64 back to 10.10 in JavaFX 17. We should bump it back to 10.12 in JavaFX 18.

This will be done in connection with JDK-8269967, PR #567, which will provide a fail-fast when attempting to run on an older version of macOS than the minimum. I will not integrate this PR until after that one is integrated.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269968: [REDO] Bump minimum version of macOS for x64 to 10.12

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/570/head:pull/570
$ git checkout pull/570

Update a local copy of the PR:
$ git checkout pull/570
$ git pull https://git.openjdk.java.net/jfx pull/570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 570

View PR using the GUI difftool:
$ git pr show -t 570

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/570.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth kevinrushforth marked this pull request as ready for review July 13, 2021 12:42
@openjdk openjdk bot added the rfr Ready for review label Jul 13, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 13, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269968: [REDO] Bump minimum version of macOS for x64 to 10.12

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 13, 2021
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2021

Going to push as commit a34928f.

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jul 13, 2021
@openjdk
Copy link

openjdk bot commented Jul 13, 2021

@kevinrushforth Pushed as commit a34928f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8269968-macOS-10.12 branch July 19, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants