8270246: Deprecate for removal implementation methods in Scene

[kevinrushforth]

The following methods in Scene were former impl_* method that were intended to be encapsulated as part of JDK-8157295 in JDK 9, but were mistakenly left as public:

    public void disposePeer()
    public void enableInputMethodEvents(boolean enable)
    public void processKeyEvent(KeyEvent e)

In the fix for JDK-8157295, the impl_ prefix was removed, and the necessary accessors were added, but the public modifier was not removed. See the diffs for these three methods in Scene.java: disposePeer, enableInputMethodEvents, processKeyEvent

We will deprecate these methods for removal with the intention to remove them from the public API in a future version of JavaFX. This will need a CSR.

NOTE: this is targeted to jfx17.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8270246: Deprecate for removal implementation methods in Scene

Reviewers

• Ambarish Rapte (@arapte - Reviewer)
• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/573/head:pull/573
$ git checkout pull/573

Update a local copy of the PR:
$ git checkout pull/573
$ git pull https://git.openjdk.java.net/jfx pull/573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 573

View PR using the GUI difftool:
$ git pr show -t 573

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/573.diff

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx17 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

/csr
/reviewers 2

[openjdk]

@kevinrushforth this pull request will not be integrated until the CSR request JDK-8270310 for issue JDK-8270246 has been approved.

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[mlbridge]

Webrevs

• 00: Full (bca73737)

[arapte]

Looks good to me.

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270246: Deprecate for removal implementation methods in Scene

Reviewed-by: arapte, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx17 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx17 branch, type /integrate in a new comment.

[kevinrushforth]

/integrate

[openjdk]

Going to push as commit 8501416.

[openjdk]

@kevinrushforth Pushed as commit 8501416.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.