Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270839: Remove deprecated implementation methods from Scene #579

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 16, 2021

This removes following implementation methods in Scene by making them package-scope. They were previously deprecated for removal by JDK-8270246:

    public void disposePeer()
    public void enableInputMethodEvents(boolean enable)
    public void processKeyEvent(KeyEvent e) 

One of the test harness classes was calling Scene::processKeyEvent directly, so I changed it to call it via SceneHelper.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270839: Remove deprecated implementation methods from Scene

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/579/head:pull/579
$ git checkout pull/579

Update a local copy of the PR:
$ git checkout pull/579
$ git pull https://git.openjdk.java.net/jfx pull/579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 579

View PR using the GUI difftool:
$ git pr show -t 579

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/579.diff

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jul 16, 2021

/csr
/reviewers 2

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr csr labels Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@kevinrushforth this pull request will not be integrated until the CSR request JDK-8270850 for issue JDK-8270839 has been approved.

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

mlbridge bot commented Jul 16, 2021

Webrevs

@kevinrushforth kevinrushforth requested review from aghaisas and arapte Jul 16, 2021
@arapte
Copy link
Member

arapte commented Jul 20, 2021

With this change, two system tests are failing with java.lang.IllegalAccessError that SceneHelper class is not accessible.

test.javafx.scene.web.HTMLEditorTest.checkFontSizeOnSelectAll_ctrl_A
test.javafx.scene.web.HTMLEditorTest.checkFontSizeOnSelectAll_Shift_LeftArrowKey

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jul 20, 2021

Good catch. I must not have run the system tests, but only compiled them (that is, ran gradle test without the -PFULL_TEST=true flag), which is not sufficient in this case. It's a simple one-line addition to the addExports file in the system tests project.

arapte
arapte approved these changes Jul 22, 2021
Copy link
Member

@arapte arapte left a comment

Looks good to me.

@openjdk openjdk bot removed the csr label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270839: Remove deprecated implementation methods from Scene

Reviewed-by: arapte, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 22, 2021
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jul 22, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

Going to push as commit 97d70af.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@kevinrushforth Pushed as commit 97d70af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8270839-rm-Scene-impl-methods branch Jul 23, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2021

Mailing list message from Kevin Rushforth on openjfx-dev:

On 7/22/2021 6:44 AM, Ajit Ghaisas wrote:

Marked as reviewed by aghaisas (Reviewer).

I'll integrate as soon as the CSR is approved (I've moved it to
"Finalized").

(Btw, I'm replying directly to the email list to see whether Skara's
`mlbridge` bot is working in this direction following the outage earlier
in the week)

-- Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants