8270839: Remove deprecated implementation methods from Scene

[kevinrushforth]

This removes following implementation methods in Scene by making them package-scope. They were previously deprecated for removal by JDK-8270246:

    public void disposePeer()
    public void enableInputMethodEvents(boolean enable)
    public void processKeyEvent(KeyEvent e) 

One of the test harness classes was calling Scene::processKeyEvent directly, so I changed it to call it via SceneHelper.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8270839: Remove deprecated implementation methods from Scene

Reviewers

• Ambarish Rapte (@arapte - Reviewer)
• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/579/head:pull/579
$ git checkout pull/579

Update a local copy of the PR:
$ git checkout pull/579
$ git pull https://git.openjdk.java.net/jfx pull/579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 579

View PR using the GUI difftool:
$ git pr show -t 579

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/579.diff

[kevinrushforth]

/csr
/reviewers 2

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinrushforth this pull request will not be integrated until the CSR request JDK-8270850 for issue JDK-8270839 has been approved.

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[mlbridge]

Webrevs

• 01: Full - Incremental (36b4a2c4)
• 00: Full (97ceedd0)

[arapte]

With this change, two system tests are failing with java.lang.IllegalAccessError that SceneHelper class is not accessible.

test.javafx.scene.web.HTMLEditorTest.checkFontSizeOnSelectAll_ctrl_A
test.javafx.scene.web.HTMLEditorTest.checkFontSizeOnSelectAll_Shift_LeftArrowKey

[kevinrushforth]

Good catch. I must not have run the system tests, but only compiled them (that is, ran gradle test without the -PFULL_TEST=true flag), which is not sufficient in this case. It's a simple one-line addition to the addExports file in the system tests project.

[arapte]

Looks good to me.

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270839: Remove deprecated implementation methods from Scene

Reviewed-by: arapte, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• c490ddf: 8269374: Menu inoperable after setting stage to second monitor
• 1992bd5: Merge
• 63c3bba: Merge
• 5a2d640: Merge
• 43bae4d: Merge
• 88a8a7c: Merge
• 83155dd: Merge
• e8e647d: Merge
• 489fff4: Merge
• 7cc1d2c: 8263111: Enhance String Conclusions
• ... and 11 more: https://git.openjdk.java.net/jfx/compare/1d97808f58aaf52c798437aff32c3efe22c4f1f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

/integrate

[openjdk]

Going to push as commit 97d70af.
Since your change was applied there have been 21 commits pushed to the master branch:

• c490ddf: 8269374: Menu inoperable after setting stage to second monitor
• 1992bd5: Merge
• 63c3bba: Merge
• 5a2d640: Merge
• 43bae4d: Merge
• 88a8a7c: Merge
• 83155dd: Merge
• e8e647d: Merge
• 489fff4: Merge
• 7cc1d2c: 8263111: Enhance String Conclusions
• ... and 11 more: https://git.openjdk.java.net/jfx/compare/1d97808f58aaf52c798437aff32c3efe22c4f1f5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth Pushed as commit 97d70af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Mailing list message from Kevin Rushforth on openjfx-dev:

On 7/22/2021 6:44 AM, Ajit Ghaisas wrote:

Marked as reviewed by aghaisas (Reviewer).

I'll integrate as soon as the CSR is approved (I've moved it to
"Finalized").

(Btw, I'm replying directly to the email list to see whether Skara's
`mlbridge` bot is working in this direction following the outage earlier
in the week)

-- Kevin