Skip to content

8270959: Update boot JDK to 16.0.2#583

Closed
kevinrushforth wants to merge 1 commit intoopenjdk:jfx17from
kevinrushforth:8270959-jdk-16.0.2
Closed

8270959: Update boot JDK to 16.0.2#583
kevinrushforth wants to merge 1 commit intoopenjdk:jfx17from
kevinrushforth:8270959-jdk-16.0.2

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 20, 2021

Update boot JDK used to build JavaFX to JDK 16.0.2, which supersedes 16.0.1.

NOTE: this is targeted to jfx17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/583/head:pull/583
$ git checkout pull/583

Update a local copy of the PR:
$ git checkout pull/583
$ git pull https://git.openjdk.java.net/jfx pull/583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 583

View PR using the GUI difftool:
$ git pr show -t 583

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/583.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx17 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member Author

I'd like two reviewers given that we are in ramp-down for JavaFX 17.

/reviewers 2

@openjdk openjdk bot added the rfr Ready for review label Jul 20, 2021
@openjdk
Copy link

openjdk bot commented Jul 20, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

mlbridge bot commented Jul 20, 2021

Webrevs

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. to me, verified Mac and Windows build.

@kevinrushforth
Copy link
Member Author

@johanvos or @tiainen can one of you be the second reviewer for this?

@johanvos
Copy link
Collaborator

We'll check on all platforms.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build succeeded on all platforms.

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270959: Update boot JDK to 16.0.2

Reviewed-by: arapte, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jfx17 branch:

  • 748f464: 8270314: TreeTableCell: inconsistent naming for tableRow and tableColumn property methods

Please see this link for an up-to-date comparison between the source branch of this pull request and the jfx17 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx17 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 23, 2021
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

Going to push as commit d540109.
Since your change was applied there has been 1 commit pushed to the jfx17 branch:

  • 748f464: 8270314: TreeTableCell: inconsistent naming for tableRow and tableColumn property methods

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jul 23, 2021
@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@kevinrushforth Pushed as commit d540109.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8270959-jdk-16.0.2 branch July 23, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants