8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's

[sashamatveev]

Fixed by not failing initialization if DSERR_NODRIVER is returned, which will be return if device is not present at all. Fixed format initialization even if DirectSound device was not created in case if audio device will arrive after playback started. Since we already handle correctly device arrival after playback started, audio will resume if device is enabled or USB audio card is plugged back. Due to lack of access to USB audio device, it was tested by disabling sound card via Device Manager, then starting playback (video plays, but not audio) and then enabling device and once enabled audio will start playing.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's

Reviewers

• Johan Vos (@johanvos - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/586/head:pull/586
$ git checkout pull/586

Update a local copy of the PR:
$ git checkout pull/586
$ git pull https://git.openjdk.java.net/jfx pull/586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 586

View PR using the GUI difftool:
$ git pr show -t 586

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/586.diff

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (2b06faed)
• 00: Full (731b4cd6)

[johanvos]

The linux test fails since b0d1586 doesn't seem to be applied to this branch.

[kevinrushforth]

@sashamatveev Can you merge in the latest upstream master into your branch? That should fix the test failures as well as being easier to test.

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[johanvos]

Looks good. I will do builds and tests, but the idea seems ok. I can imagine it's very hard to have a unit or even system test for this.

[kevinrushforth]

Looks good to me. I didn't fully verify the fix on a system without speakers (although I did some limited testing), but did run a set of regression tests.

[johanvos]

Looks good. In the old and new code, there are some memory operations that I'm a little worried about, but as far as I can tell there are no changes related to that between the old and the new code -- at least I don't see a scenario where a free occurs now while it didn't occur before.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's

Reviewed-by: jvos, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

Going to push as commit b738e1c.

[openjdk]

@sashamatveev Pushed as commit b738e1c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.