-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271230: Remove obsolete test classes and data files from 3DViewer sample #587
8271230: Remove obsolete test classes and data files from 3DViewer sample #587
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, verified that 3DViewer test builds and runs properly after removing these files.
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 0e5b788. |
@kevinrushforth Pushed as commit 0e5b788. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove the obsolete
apps/samples/3DViewer/src/test
directory from the 3DViewer sample, including two test classes that don't run and a set of data files that won't load. This is a follow-on cleanup bug to JDK-8269259.NOTE: this is targeted to
jfx17
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/587/head:pull/587
$ git checkout pull/587
Update a local copy of the PR:
$ git checkout pull/587
$ git pull https://git.openjdk.java.net/jfx pull/587/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 587
View PR using the GUI difftool:
$ git pr show -t 587
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/587.diff