Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271230: Remove obsolete test classes and data files from 3DViewer sample #587

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 24, 2021

Remove the obsolete apps/samples/3DViewer/src/test directory from the 3DViewer sample, including two test classes that don't run and a set of data files that won't load. This is a follow-on cleanup bug to JDK-8269259.

NOTE: this is targeted to jfx17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271230: Remove obsolete test classes and data files from 3DViewer sample

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/587/head:pull/587
$ git checkout pull/587

Update a local copy of the PR:
$ git checkout pull/587
$ git pull https://git.openjdk.java.net/jfx pull/587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 587

View PR using the GUI difftool:
$ git pr show -t 587

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/587.diff

@kevinrushforth kevinrushforth requested a review from arapte Jul 24, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 24, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx17 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 24, 2021

Webrevs

arapte
arapte approved these changes Jul 26, 2021
Copy link
Member

@arapte arapte left a comment

Looks good, verified that 3DViewer test builds and runs properly after removing these files.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271230: Remove obsolete test classes and data files from 3DViewer sample

Reviewed-by: arapte, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx17 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx17 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 26, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 26, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

Going to push as commit 0e5b788.

@openjdk openjdk bot closed this Jul 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@kevinrushforth Pushed as commit 0e5b788.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8271230-rm-3DViewer-test branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants