Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8212088: Missing copyright notices for property files #591

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 28, 2021

This PR adds missing copyright header blocks for several properties files, script files, and textual data files (e.g., fxml, css) that do not have them. Where feasible, all non-trivial textual files in the repo should have a proper copyright header.

Notes to Reviewers

  • This PR is targeted to the jfx17 branch.
  • There are two commits that can be reviewed separately, if you prefer. The first covers most of the files, and adds a copyright header with a GPL v2 + classpath license. The second is for the apps/samples only, which adds a copyright header with a BSD-style license.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8212088: Missing copyright notices for property files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/591/head:pull/591
$ git checkout pull/591

Update a local copy of the PR:
$ git checkout pull/591
$ git pull https://git.openjdk.java.net/jfx pull/591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 591

View PR using the GUI difftool:
$ git pr show -t 591

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/591.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx17 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member Author

/reviewers 2

@openjdk openjdk bot added the rfr Ready for review label Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

@johanvos
Copy link
Collaborator

Is there a reason why the samples have a BSD license while the others have GPL + CPE? (not that I'm against BSD, just wondering)

@kevinrushforth
Copy link
Member Author

Yes. All of JavaFX is licensed under GPL except for the sample applications under apps/samples, which are licensed under BSD (apps/scenebuilder was similarly licensed under BSD before it was removed from the repo).

@kevinrushforth
Copy link
Member Author

I should add, that the JDK samples are similarly licensed under BSD, so JavaFX followed suit (the JavaFX samples are bundled with the JDK samples in JDK 8).

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8212088: Missing copyright notices for property files

Reviewed-by: jvos, arapte, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the jfx17 branch:

  • 78a3721: 8271086: Block comments of form '/***' are treated as javadoc comments
  • 2cd5d1f: 8240640: [macos] Wrong focus behaviour with multiple Alerts

Please see this link for an up-to-date comparison between the source branch of this pull request and the jfx17 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx17 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 28, 2021
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

Going to push as commit df07ac8.
Since your change was applied there have been 2 commits pushed to the jfx17 branch:

  • 78a3721: 8271086: Block comments of form '/***' are treated as javadoc comments
  • 2cd5d1f: 8240640: [macos] Wrong focus behaviour with multiple Alerts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@kevinrushforth Pushed as commit df07ac8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8212088-copyr-props branch July 29, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants