-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8212088: Missing copyright notices for property files #591
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
Is there a reason why the samples have a BSD license while the others have GPL + CPE? (not that I'm against BSD, just wondering) |
Yes. All of JavaFX is licensed under GPL except for the sample applications under |
I should add, that the JDK samples are similarly licensed under BSD, so JavaFX followed suit (the JavaFX samples are bundled with the JDK samples in JDK 8). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit df07ac8.
Your commit was automatically rebased without conflicts. |
@kevinrushforth Pushed as commit df07ac8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR adds missing copyright header blocks for several properties files, script files, and textual data files (e.g., fxml, css) that do not have them. Where feasible, all non-trivial textual files in the repo should have a proper copyright header.
Notes to Reviewers
jfx17
branch.apps/samples
only, which adds a copyright header with a BSD-style license.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/591/head:pull/591
$ git checkout pull/591
Update a local copy of the PR:
$ git checkout pull/591
$ git pull https://git.openjdk.java.net/jfx pull/591/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 591
View PR using the GUI difftool:
$ git pr show -t 591
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/591.diff