Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272329: Cherry pick GTK WebKit 2.32.3 changes #603

Closed
wants to merge 2 commits into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Aug 13, 2021

Cherry pick the GTK webkit 2.32.3 changes
https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/603/head:pull/603
$ git checkout pull/603

Update a local copy of the PR:
$ git checkout pull/603
$ git pull https://git.openjdk.java.net/jfx pull/603/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 603

View PR using the GUI difftool:
$ git pr show -t 603

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/603.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 13, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2021

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Aug 13, 2021

/reviewers 2

@openjdk
Copy link

openjdk bot commented Aug 13, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Tested on all platforms.

I left one question for you, but it's more out of curiosity.

@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272329: Cherry pick GTK WebKit 2.32.3 changes

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 17, 2021
@arapte
Copy link
Member Author

arapte commented Aug 17, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 17, 2021

Going to push as commit ee442e5.

@openjdk openjdk bot closed this Aug 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Aug 17, 2021
@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@arapte Pushed as commit ee442e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants