New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272329: Cherry pick GTK WebKit 2.32.3 changes #603
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
Webrevs
|
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested on all platforms.
I left one question for you, but it's more out of curiosity.
modules/javafx.web/src/main/native/Source/WebCore/page/FrameViewLayoutContext.cpp
Outdated
Show resolved
Hide resolved
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ee442e5. |
Cherry pick the GTK webkit 2.32.3 changes
https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/603/head:pull/603
$ git checkout pull/603
Update a local copy of the PR:
$ git checkout pull/603
$ git pull https://git.openjdk.java.net/jfx pull/603/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 603
View PR using the GUI difftool:
$ git pr show -t 603
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/603.diff