8269081: Tree/ListViewSkin: must remove flow on dispose

[kleopatra]

left-over issue from cleanup of Tree/ListViewSkin: direct children that have been added by the skin must be removed in dispose

fixed by removing the flow (which allowed to revert the previous cleanup of event handlers/cellfactory)

added tests to verify

• constant child count after replacing skin
• no memory leak when switching skin while showing

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269081: Tree/ListViewSkin: must remove flow on dispose

Reviewers

• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/612/head:pull/612
$ git checkout pull/612

Update a local copy of the PR:
$ git checkout pull/612
$ git pull https://git.openjdk.java.net/jfx pull/612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 612

View PR using the GUI difftool:
$ git pr show -t 612

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/612.diff

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (2271288f)

[arapte]

Looks good to me.

[openjdk]

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269081: Tree/ListViewSkin: must remove flow on dispose

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

Going to push as commit e931501.

[openjdk]

@kleopatra Pushed as commit e931501.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.