New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8270107: Open source FXMediaPlayer test app #613
Conversation
|
By way of background this is a lightly cleaned up version of a closed-source test program that we are open sourcing in order to facilitate testing various media features. Even though it is a test program, I'd like a second pair of eyes on it. /reviewers 2 |
@kevinrushforth |
That's great. I agree a global media sample would be an excellent improvement for testing (regression on) media. I notice there are a number of netbeans-impl files, which is ok for me, unless we want to avoid ide-specific impl files? Rather than requesting many changes (e.g. bump java version) before it is in the repository, I think it would be good to do some sanity tests on the different platforms and then include it. I plan to do that later this weekend. |
I agree with getting it in now (after testing) and then improving it after it is in the repo. Btw, the A good cleanup effort would be to rewrite them to remove the NetBeans project structure, but that would be a larger effort than just this one manual test program. |
On Aug 28, 2021, at 11:51 AM, Kevin Rushforth ***@***.***> wrote:
I agree with getting it in now (after testing) and then improving it after it is in the repo.
Btw, the nbproject/ files were derived from those in the apps/toys/ directory, for example, apps/toys/Hello/nbproject/ <https://github.com/openjdk/jfx/tree/68db44a2c80f420c967c64bb85988178a3cf6d9c/apps/toys/Hello/nbproject>, and similarly are used to build using ant. So they aren't really IDE files any longer, even though that's where they originated back in the FX 2 time frame.
A good cleanup effort would be to rewrite them to remove the NetBeans project structure, but that would be a larger effort than just this one manual test program.
Would be nice to have part of the cleanup convert projects to Gradle to be consistent with the rest of the project.
Scott
|
I partially tested it, will do the remainder now. |
@sashamatveev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Going to push as commit 51265c0.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit 51265c0. |
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/613/head:pull/613
$ git checkout pull/613
Update a local copy of the PR:
$ git checkout pull/613
$ git pull https://git.openjdk.java.net/jfx pull/613/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 613
View PR using the GUI difftool:
$ git pr show -t 613
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/613.diff