Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273343: Create release notes for JavaFX 17 #619

Closed
wants to merge 2 commits into from

Conversation

@abhinayagarwal
Copy link
Contributor

@abhinayagarwal abhinayagarwal commented Sep 7, 2021

Add release notes for JavaFX 17 to the repository


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/619/head:pull/619
$ git checkout pull/619

Update a local copy of the PR:
$ git checkout pull/619
$ git pull https://git.openjdk.java.net/jfx pull/619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 619

View PR using the GUI difftool:
$ git pr show -t 619

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/619.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2021

👋 Welcome back abhinayagarwal! A progress list of the required criteria for merging this PR into jfx17 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2021

Webrevs

@johanvos johanvos requested review from johanvos and kevinrushforth Sep 7, 2021
doc-files/release-notes-17.md Outdated Show resolved Hide resolved
Copy link
Member

@kevinrushforth kevinrushforth left a comment

I noted a few bugs that probably shouldn't be on this list. The rest looks good.

## List of Sub-task

Issue key|Summary|Subcomponent
---------|-------|------------
[JDK-8092439](https://bugs.openjdk.java.net/browse/JDK-8092439)|[Monocle] Refactor monocle SPI to allow support for multiple screens|graphics
Copy link
Member

@kevinrushforth kevinrushforth Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is just refactoring, I probably wouldn't mention it in the release notes. I added the noreg-cleanup label in JBS.

Copy link
Collaborator

@johanvos johanvos Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit does more than refactoring the SPI, so the issue was probably not the best one to link with this PR.

Copy link
Member

@kevinrushforth kevinrushforth Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the noreg-cleanup label.

[JDK-8239138](https://bugs.openjdk.java.net/browse/JDK-8239138)|StyleManager should use a BufferedInputStream|controls
[JDK-8244075](https://bugs.openjdk.java.net/browse/JDK-8244075)|Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene|controls
[JDK-8252238](https://bugs.openjdk.java.net/browse/JDK-8252238)|TableView: Editable (pseudo-editable) cells should respect the row editability|controls
[JDK-8252820](https://bugs.openjdk.java.net/browse/JDK-8252820)|Skins: cleanup use of deprecated snapSize/snapPosition|controls
Copy link
Member

@kevinrushforth kevinrushforth Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove?

[JDK-8259718](https://bugs.openjdk.java.net/browse/JDK-8259718)|Remove the Marlin rasterizer (single-precision)|graphics
[JDK-8267551](https://bugs.openjdk.java.net/browse/JDK-8267551)|Support loading images from inline data-URIs|graphics
[JDK-8268120](https://bugs.openjdk.java.net/browse/JDK-8268120)|Allow hardware cursor to be used on Monocle-EGL platforms|graphics
[JDK-8257895](https://bugs.openjdk.java.net/browse/JDK-8257895)|Allow building of JavaFX media libs for Apple Silicon|media
Copy link
Member

@kevinrushforth kevinrushforth Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove?

[JDK-8262396](https://bugs.openjdk.java.net/browse/JDK-8262396)|Update Mesa 3-D Headers to version 21.0.3|graphics
[JDK-8262802](https://bugs.openjdk.java.net/browse/JDK-8262802)|Wrong context origin coordinates when using EGL and HiDPI|graphics
[JDK-8263402](https://bugs.openjdk.java.net/browse/JDK-8263402)|MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene|graphics
[JDK-8263778](https://bugs.openjdk.java.net/browse/JDK-8263778)|Fix monocle JNI signatures for instance methods|graphics
Copy link
Member

@kevinrushforth kevinrushforth Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove?

[JDK-8263778](https://bugs.openjdk.java.net/browse/JDK-8263778)|Fix monocle JNI signatures for instance methods|graphics
[JDK-8267160](https://bugs.openjdk.java.net/browse/JDK-8267160)|Monocle mouse never get ENTERED state|graphics
[JDK-8267314](https://bugs.openjdk.java.net/browse/JDK-8267314)|Loading some animated GIFs fails with ArrayIndexOutOfBoundsException: Index 4096 out of bounds for length 4096|graphics
[JDK-8267621](https://bugs.openjdk.java.net/browse/JDK-8267621)|Mark HonorDeveloperSettingsTest as unstable on Linux|graphics
Copy link
Member

@kevinrushforth kevinrushforth Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test bug (I just added the missing label), so need not be listed.

[JDK-8260165](https://bugs.openjdk.java.net/browse/JDK-8260165)|CSSFilterTest.testCSSFilterRendering system test fails|web
[JDK-8260245](https://bugs.openjdk.java.net/browse/JDK-8260245)|Update ICU4C to version 68.2|web
[JDK-8260257](https://bugs.openjdk.java.net/browse/JDK-8260257)|[Linux] WebView no longer reacts to some mouse events|web
[JDK-8261927](https://bugs.openjdk.java.net/browse/JDK-8261927)|WebKit build fails with Visual Studio 2017|web
Copy link
Member

@kevinrushforth kevinrushforth Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove?

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@abhinayagarwal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273343: Create release notes for JavaFX 17

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx17 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 7, 2021
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@abhinayagarwal
Copy link
Contributor Author

@abhinayagarwal abhinayagarwal commented Sep 7, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@abhinayagarwal
Your change (at version 58d6bb0) is now ready to be sponsored by a Committer.

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Sep 7, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

Going to push as commit 24d0600.

@openjdk openjdk bot closed this Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@johanvos @abhinayagarwal Pushed as commit 24d0600.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants