Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271474: Tree-/TableCell: inconsistent edit event firing pattern #620

Closed
wants to merge 1 commit into from

Conversation

@kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented Sep 7, 2021

this PR fixes the inconsistent event firing pattern in cell's xxEdit methods (please see the issue for more details):

  • fires event if column != null
  • accesses table state if table != null

The first requires a change in CellEditEvent which now allows null table in its constructor.

Added tests that failed/passed before/after the fix (along with some that also passed before for complete coverage of state permutations). Changed two old test methods which passed/failed before/after the fix - but did test the wrong thingy anyway ;)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271474: Tree-/TableCell: inconsistent edit event firing pattern

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/620/head:pull/620
$ git checkout pull/620

Update a local copy of the PR:
$ git checkout pull/620
$ git pull https://git.openjdk.java.net/jfx pull/620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 620

View PR using the GUI difftool:
$ git pr show -t 620

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/620.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2021

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2021

Webrevs

@kevinrushforth kevinrushforth requested review from aghaisas and arapte Sep 7, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 7, 2021

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@Maran23 Maran23 left a comment

Looks good to me. 👍

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271474: Tree-/TableCell: inconsistent edit event firing pattern

Reviewed-by: mhanl, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 4b9cb21: 8273969: Memory Leak on the Runnable provided to Platform.startup
  • 338b999: 8273946: Move clearQuad method to BaseShaderGraphics superclass
  • 5c355fa: 8090158: Wrong implementation of adjustValue in scrollBars
  • f59a057: 8090547: Allow for transparent backgrounds in WebView
  • d356340: 8172095: Let Node.managed become CSS-styleable
  • b2ecfac: 8271398: GTK3 drag view image swaps red and blue color channels
  • 7329279: 8273754: Re-introduce Automatic-Module-Name in empty jars
  • 51265c0: 8270107: Open source FXMediaPlayer test app
  • f987b18: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel
  • a272c4f: 8273324: IllegalArgumentException: fromIndex(0) > toIndex(-1) after clear and select TableCell
  • ... and 3 more: https://git.openjdk.java.net/jfx/compare/78ae4a815b728f5a0dca8fa6de8ca68a27a1d189...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 24, 2021
@kleopatra
Copy link
Collaborator Author

@kleopatra kleopatra commented Sep 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

Going to push as commit 55faac4.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@kleopatra Pushed as commit 55faac4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kleopatra kleopatra deleted the bug-fix-8271474 branch Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants