Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273824: Update JavaFX release version to 17.0.0.1 in jfx/jfx17 branch #624

Closed
wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Sep 15, 2021

This release is needed with a backport of JDK-8273754


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273824: Update JavaFX release version to 17.0.0.1 in jfx/jfx17 branch

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/624/head:pull/624
$ git checkout pull/624

Update a local copy of the PR:
$ git checkout pull/624
$ git pull https://git.openjdk.java.net/jfx pull/624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 624

View PR using the GUI difftool:
$ git pr show -t 624

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/624.diff

@johanvos johanvos requested a review from kevinrushforth Sep 15, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx17 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273824: Update JavaFX release version to 17.0.0.1 in jfx/jfx17 branch

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx17 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx17 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Sep 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

Going to push as commit bd87240.

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@johanvos Pushed as commit bd87240.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants