Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273969: Memory Leak on the Runnable provided to Platform.startup #626

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -376,6 +376,7 @@ void runToolkit() {
launchLatch.countDown();
try {
Application.invokeAndWait(this.userRunnable);
this.userRunnable = null;

if (getPrimaryTimer().isFullspeed()) {
/*
@@ -0,0 +1,48 @@
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation. Oracle designates this
* particular file as subject to the "Classpath" exception as provided
* by Oracle in the LICENSE file that accompanied this code.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

package test.javafx.scene;
FlorianKirmaier marked this conversation as resolved.
Show resolved Hide resolved

import org.junit.Test;
import test.util.memory.JMemoryBuddy;
import javafx.application.Platform;

public class PlatformStartupMemoryLeakTest {

@Test
kevinrushforth marked this conversation as resolved.
Show resolved Hide resolved
public void testStartupLeak() {
JMemoryBuddy.memoryTest((checker) -> {
// Doesn't work as lambda for some reason, due to "BoundMethodHandle$Species_L"
kevinrushforth marked this conversation as resolved.
Show resolved Hide resolved
Runnable r = new Runnable() {
@Override
public void run() {
System.out.println("Startup called!");
}
};
Platform.startup(r);
checker.assertCollectable(r);
});
}
kevinrushforth marked this conversation as resolved.
Show resolved Hide resolved
}