Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274433: All Cells: misbehavior of startEdit #636

Closed
wants to merge 2 commits into from

Conversation

@kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented Sep 30, 2021

The misbehavior happens if (super) startEdit didn't succeed (== !cell.isEditing):

  • must not fire editStart event
  • must not update control's editing location

fix is to back out of startEdit if super.startEdit doesn't switch the cell into editing mode

Added tests that failed/passed before/after the fix. Note that for Tree-, Table-, TreeTableCell one of the added tests would be a false green due to those cells not updating the editing location on its control JDK-8187474, so it's ignore until that's fixed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/636/head:pull/636
$ git checkout pull/636

Update a local copy of the PR:
$ git checkout pull/636
$ git pull https://git.openjdk.java.net/jfx pull/636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 636

View PR using the GUI difftool:
$ git pr show -t 636

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/636.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 30, 2021

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 30, 2021

Webrevs

@kevinrushforth kevinrushforth requested a review from aghaisas Sep 30, 2021
Copy link
Member

@Maran23 Maran23 left a comment

Change looks good, I just left some comments on the tests. :)

Maran23
Maran23 approved these changes Oct 1, 2021
Copy link
Member

@Maran23 Maran23 left a comment

Looks good!

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Oct 4, 2021

The fix is fine!

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274433: All Cells: misbehavior of startEdit

Reviewed-by: mhanl, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 64aa926: 8188026: TextFieldXXCell: NPE on calling startEdit
  • f3c72b9: 8214158: Implement HostServices.showDocument on macOS without calling AWT

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 4, 2021
@kleopatra
Copy link
Collaborator Author

@kleopatra kleopatra commented Oct 4, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

Going to push as commit 2c86e0f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 64aa926: 8188026: TextFieldXXCell: NPE on calling startEdit
  • f3c72b9: 8214158: Implement HostServices.showDocument on macOS without calling AWT

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@kleopatra Pushed as commit 2c86e0f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kleopatra kleopatra deleted the bug-fix-8274433 branch Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants