8271091: Missing API docs in UI controls classes

[aghaisas]

This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
Note :

• The javadoc needs to be generated with the JDK 18 EA build.
• 2 javadoc warnings in javafx.controls TabPane class will be fixed under - JDK-8271085
• There are still 20 javadoc warnings remaining in javafx.controls module and 3 warnings remaining in javafx.web module. The root cause is different and they will be addressed under JDK-8270996

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271091: Missing API docs in UI controls classes

Reviewers

• Nir Lisker (@nlisker - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/646/head:pull/646
$ git checkout pull/646

Update a local copy of the PR:
$ git checkout pull/646
$ git pull https://git.openjdk.java.net/jfx pull/646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 646

View PR using the GUI difftool:
$ git pr show -t 646

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/646.diff

[bridgekeeper]

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 04: Full - Incremental (1ab36f72)
• 03: Full - Incremental (b4d5dc4f)
• 02: Full - Incremental (7cc2de52)
• 01: Full - Incremental (38563835)
• 00: Full (6f802004)

[nlisker]

Took a quick look at the new docs. I didn't check the resulting HTML or the corrected of the description, just format and grammar.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

See comments below.

[kevinrushforth]

Two minor comments. The rest looks great.

[aghaisas]

@nlisker, can you please take a look and approve?

[kevinrushforth]

The doc changes look good. Please revert the access modifier change.

[kevinrushforth]

This looks good. I confirmed that the implicit constructor for PopupControl.CSSBridge is protected in JavaFX 17, so making the explicitly added contructor be protected is correct.

[nlisker]

I didn't check the generated HTML pages or the correctness of the docs with respect to the functionality of their methods, but the docs themselves look good.

[openjdk]

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271091: Missing API docs in UI controls classes

Reviewed-by: nlisker, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 717cfdc: 8274669: Dialog sometimes ignores max height
• d244b30: 8275815: OCA link in README.md and CONTRIBUTING.md is broken
• 28e8684: 8272638: Update copyright header for files modified in 2021
• 7be0abb: 8274413: FX: Update copyright year in docs, readme files to 2022
• a118d33: 8236689: macOS 10.15 Catalina: LCD text renders badly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[aghaisas]

/integrate

[openjdk]

Going to push as commit a947405.
Since your change was applied there have been 6 commits pushed to the master branch:

• e7a106f: 8271090: Missing API docs in scenegraph classes
• 717cfdc: 8274669: Dialog sometimes ignores max height
• d244b30: 8275815: OCA link in README.md and CONTRIBUTING.md is broken
• 28e8684: 8272638: Update copyright header for files modified in 2021
• 7be0abb: 8274413: FX: Update copyright year in docs, readme files to 2022
• a118d33: 8236689: macOS 10.15 Catalina: LCD text renders badly

Your commit was automatically rebased without conflicts.

[openjdk]

@aghaisas Pushed as commit a947405.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.