Skip to content

Conversation

@arapte
Copy link
Member

@arapte arapte commented Oct 20, 2021

Change to update copyright year of files modified in 2021.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272638: Update copyright header for files modified in 2021

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/648/head:pull/648
$ git checkout pull/648

Update a local copy of the PR:
$ git checkout pull/648
$ git pull https://git.openjdk.java.net/jfx pull/648/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 648

View PR using the GUI difftool:
$ git pr show -t 648

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/648.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Oct 20, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2021

Webrevs

@kevinrushforth kevinrushforth self-requested a review October 20, 2021 22:33
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272638: Update copyright header for files modified in 2021

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Oct 20, 2021
@arapte
Copy link
Member Author

arapte commented Oct 21, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2021

Going to push as commit 28e8684.

@openjdk openjdk bot closed this Oct 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Oct 21, 2021
@openjdk
Copy link

openjdk bot commented Oct 21, 2021

@arapte Pushed as commit 28e8684.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the copyright-year branch May 10, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants