Skip to content

8275815: OCA link in README.md and CONTRIBUTING.md is broken#652

Closed
kevinrushforth wants to merge 1 commit intoopenjdk:masterfrom
kevinrushforth:8275815-oca-link
Closed

8275815: OCA link in README.md and CONTRIBUTING.md is broken#652
kevinrushforth wants to merge 1 commit intoopenjdk:masterfrom
kevinrushforth:8275815-oca-link

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 22, 2021

The PR fixes the broken links as described in the JBS issue. The correct link for the Oracle Contributor Agreement (OCA) is:

https://oca.opensource.oracle.com/


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275815: OCA link in README.md and CONTRIBUTING.md is broken

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/652/head:pull/652
$ git checkout pull/652

Update a local copy of the PR:
$ git checkout pull/652
$ git pull https://git.openjdk.java.net/jfx pull/652/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 652

View PR using the GUI difftool:
$ git pr show -t 652

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/652.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Oct 22, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275815: OCA link in README.md and CONTRIBUTING.md is broken

Reviewed-by: nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Oct 22, 2021
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

Going to push as commit d244b30.

@openjdk openjdk bot closed this Oct 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Oct 22, 2021
@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@kevinrushforth Pushed as commit d244b30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8275815-oca-link branch October 23, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants