8275911: Keyboard doesn't show when tapping inside an iOS text input control#653
8275911: Keyboard doesn't show when tapping inside an iOS text input control#653jperedadnr wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into |
|
Changes look OK to me. Since they are confined to iOS-specific files, I'll leave it to @johanvos to review. |
|
@jperedadnr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 7d6493b.
Your commit was automatically rebased without conflicts. |
|
@jperedadnr Pushed as commit 7d6493b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
After JDK-8245053 for Android, this PR applies the same approach on iOS: tapping on a text input control on iOS shows the keyboard, which hides after the control loses the focus.
Now, both platforms have the same behaviour.
Tested on an iOS device.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/653/head:pull/653$ git checkout pull/653Update a local copy of the PR:
$ git checkout pull/653$ git pull https://git.openjdk.java.net/jfx pull/653/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 653View PR using the GUI difftool:
$ git pr show -t 653Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/653.diff