Skip to content

8275911: Keyboard doesn't show when tapping inside an iOS text input control#653

Closed
jperedadnr wants to merge 1 commit intoopenjdk:masterfrom
jperedadnr:8275911-keyboardios
Closed

8275911: Keyboard doesn't show when tapping inside an iOS text input control#653
jperedadnr wants to merge 1 commit intoopenjdk:masterfrom
jperedadnr:8275911-keyboardios

Conversation

@jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Oct 26, 2021

After JDK-8245053 for Android, this PR applies the same approach on iOS: tapping on a text input control on iOS shows the keyboard, which hides after the control loses the focus.

Now, both platforms have the same behaviour.

Tested on an iOS device.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275911: Keyboard doesn't show when tapping inside an iOS text input control

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/653/head:pull/653
$ git checkout pull/653

Update a local copy of the PR:
$ git checkout pull/653
$ git pull https://git.openjdk.java.net/jfx pull/653/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 653

View PR using the GUI difftool:
$ git pr show -t 653

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/653.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2021

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Oct 26, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2021

Webrevs

@kevinrushforth
Copy link
Member

Changes look OK to me. Since they are confined to iOS-specific files, I'll leave it to @johanvos to review.

@openjdk
Copy link

openjdk bot commented Nov 4, 2021

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275911: Keyboard doesn't show when tapping inside an iOS text input control

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • cde72c8: 8276179: PrismFontFile.isInstalledFont is dead code and should be removed
  • 6c88106: 8222455: JavaFX error loading glass.dll from cache
  • c6f4ff0: 8274699: Certain blend modes cannot be set from CSS
  • d9e1ad9: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box
  • 161e434: 8255015: Inconsistent illumination of 3D shape by PointLight
  • adcc40d: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit
  • a947405: 8271091: Missing API docs in UI controls classes
  • e7a106f: 8271090: Missing API docs in scenegraph classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 4, 2021
@jperedadnr
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2021

Going to push as commit 7d6493b.
Since your change was applied there have been 8 commits pushed to the master branch:

  • cde72c8: 8276179: PrismFontFile.isInstalledFont is dead code and should be removed
  • 6c88106: 8222455: JavaFX error loading glass.dll from cache
  • c6f4ff0: 8274699: Certain blend modes cannot be set from CSS
  • d9e1ad9: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box
  • 161e434: 8255015: Inconsistent illumination of 3D shape by PointLight
  • adcc40d: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit
  • a947405: 8271091: Missing API docs in UI controls classes
  • e7a106f: 8271090: Missing API docs in scenegraph classes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Nov 4, 2021
@openjdk
Copy link

openjdk bot commented Nov 4, 2021

@jperedadnr Pushed as commit 7d6493b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants