Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276179 PrismFontFile.isInstalledFont is dead code and should be removed #658

Conversation

FlorianKirmaier
Copy link
Member

@FlorianKirmaier FlorianKirmaier commented Oct 29, 2021

removing dead code.
When looking into the font code, I've noticed that this code is no longer used, so I thought I should make a PR with a minor cleanup.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276179: PrismFontFile.isInstalledFont is dead code and should be removed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/658/head:pull/658
$ git checkout pull/658

Update a local copy of the PR:
$ git checkout pull/658
$ git pull https://git.openjdk.java.net/jfx pull/658/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 658

View PR using the GUI difftool:
$ git pr show -t 658

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/658.diff

removing dead code
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2021

👋 Welcome back fkirmaier! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 29, 2021

Webrevs

@kevinrushforth kevinrushforth requested a review from prrace Oct 29, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 29, 2021

A quick look suggests that this is, in fact, unused. I would like Phil to review it, though.

@FlorianKirmaier
Copy link
Member Author

@FlorianKirmaier FlorianKirmaier commented Oct 29, 2021

I've also seen many places in the font code, which just catch Exceptions without handling them, nor logging them.
This is really frightening when investigating issues with fonts.
It seems like some Exceptions are expected, but it's not known which Exceptions are expected. No wonder the font-loading features often feel unstable.

Should I also make a PR for this problem?

prrace
prrace approved these changes Oct 29, 2021
@prrace
Copy link
Collaborator

@prrace prrace commented Oct 29, 2021

I'm quite confident the build will be a good test of whether it is unused so fine by me.
I am a little curious as to when it stopped being used and why .. but that isn't a blocker.

prrace
prrace approved these changes Oct 29, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 29, 2021

I've also seen many places in the font code, which just catch Exceptions without handling them, nor logging them. This is really frightening when investigating issues with fonts. It seems like some Exceptions are expected, but it's not known which Exceptions are expected. No wonder the font-loading features often feel unstable.

You can file a new bug if you like. As long as we don't start getting noise from exceptions that don't matter, it seems a good idea to log them when they happen.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 30, 2021

JDK-8276179: PrismFontFile.isInstalledFont is dead code and should be removed ⚠️ Title mismatch between PR and JBS.

@FlorianKirmaier except for the above problem with the title of this PR, it is ready to be integrated. Once you update this PR's title, Skara will mark it as ready.

@FlorianKirmaier FlorianKirmaier changed the title 8276179 removing unused font code - isInstalledFont 8276179 PrismFontFile.isInstalledFont is dead code and should be removed Nov 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@FlorianKirmaier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276179: PrismFontFile.isInstalledFont is dead code and should be removed

Reviewed-by: prr, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 6c88106: 8222455: JavaFX error loading glass.dll from cache
  • c6f4ff0: 8274699: Certain blend modes cannot be set from CSS
  • d9e1ad9: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box
  • 161e434: 8255015: Inconsistent illumination of 3D shape by PointLight
  • adcc40d: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit
  • a947405: 8271091: Missing API docs in UI controls classes
  • e7a106f: 8271090: Missing API docs in scenegraph classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 1, 2021
@FlorianKirmaier
Copy link
Member Author

@FlorianKirmaier FlorianKirmaier commented Nov 2, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2021

@FlorianKirmaier
Your change (at version 715614e) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 2, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2021

Going to push as commit cde72c8.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 6c88106: 8222455: JavaFX error loading glass.dll from cache
  • c6f4ff0: 8274699: Certain blend modes cannot be set from CSS
  • d9e1ad9: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box
  • 161e434: 8255015: Inconsistent illumination of 3D shape by PointLight
  • adcc40d: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit
  • a947405: 8271091: Missing API docs in UI controls classes
  • e7a106f: 8271090: Missing API docs in scenegraph classes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2021

@kevinrushforth @FlorianKirmaier Pushed as commit cde72c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants