8275723: Crash on macOS 12 in GlassRunnable::dealloc

[bae]

GlassRunnable uses jni environment (jEnv) associated with the main application thread both for run() and dealloc() methods. Both these methods are supposed to be scheduled for execution on the main thread:

if (jEnv != NULL)
{
  GlassRunnable *runnable = [[GlassRunnable alloc] initWithRunnable:(*env)->NewGlobalRef(env, jRunnable)];
  [runnable performSelectorOnMainThread:@selector(run) withObject:nil waitUntilDone:NO];
} 

However, it appears that on macOS 12 only the run() method is executed the main thread, whereas the dealloc() method is executed on the InvokeLaterDispatcher thread, that leads to usage of the main thread jni env in the context of another thread. This problem is more visible on aarch64, where the thread check is triggered by the W^X machinery, but the problem is present on x64 as well.

Proposed fix just encapsulates all jni-related work in the run() method, reducing risks to misuse the jni environment of the main thread.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275723: Crash on macOS 12 in GlassRunnable::dealloc

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Johan Vos (@johanvos - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/661/head:pull/661
$ git checkout pull/661

Update a local copy of the PR:
$ git checkout pull/661
$ git pull https://git.openjdk.java.net/jfx pull/661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 661

View PR using the GUI difftool:
$ git pr show -t 661

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/661.diff

[bridgekeeper]

👋 Welcome back bae! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[mlbridge]

Webrevs

• 00: Full (47b4d0fb)

[kevinrushforth]

The fix looks good. All my testing so far looks good. I'll finish my testing today.

[johanvos]

The fix looks good. All my testing so far looks good. I'll finish my testing today.

same here.

[kevinrushforth]

Testing completed. I ran tests on three different macOS systems:

M1 running macOS 12.0.1 beta
Intel x64 system running macOS 12.0.1 beta
Intel x64 system (MacBook Pro) running 10.15.7

[johanvos]

This indeed fixes the issue, and doesn't cause regression.

[openjdk]

@bae This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275723: Crash on macOS 12 in GlassRunnable::dealloc

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 5fc047b: 8272808: Update constant collections to use the new immutable collections - leftovers
• 7d6493b: 8275911: Keyboard doesn't show when tapping inside an iOS text input control
• cde72c8: 8276179: PrismFontFile.isInstalledFont is dead code and should be removed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bae]

/integrate

[openjdk]

@bae
Your change (at version 47b4d0f) is now ready to be sponsored by a Committer.

[johanvos]

/sponsor

[openjdk]

Going to push as commit 4d8e12d.
Since your change was applied there have been 3 commits pushed to the master branch:

• 5fc047b: 8272808: Update constant collections to use the new immutable collections - leftovers
• 7d6493b: 8275911: Keyboard doesn't show when tapping inside an iOS text input control
• cde72c8: 8276179: PrismFontFile.isInstalledFont is dead code and should be removed

Your commit was automatically rebased without conflicts.

[openjdk]

@johanvos @bae Pushed as commit 4d8e12d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.