Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver #664

Closed
wants to merge 3 commits into from

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Nov 10, 2021

This PR enables intersection observer support for WebKit, and includes a system test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/664/head:pull/664
$ git checkout pull/664

Update a local copy of the PR:
$ git checkout pull/664
$ git pull https://git.openjdk.java.net/jfx pull/664/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 664

View PR using the GUI difftool:
$ git pr show -t 664

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/664.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 10, 2021

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 10, 2021

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 10, 2021

This looks like a reasonable thing to do.

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@jperedadnr
Copy link
Collaborator Author

@jperedadnr jperedadnr commented Nov 23, 2021

Worth pointing out that JDK-8273558 gets fixed with this PR.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I've tested this on all platforms and confirm that it fixes the issue with no regressions that I can see. I also confirm that the new test catches the problem (fails without and passes with the fix), and that this fixes JDK-8273558, which can be closed as a duplicate.

I left one minor formatting comment, but unless there are other changes, it probably isn't worth changing it.

</div>
<div id="output">Intersection ratio: <pre>?</pre></div>
</body>
</html>
Copy link
Member

@kevinrushforth kevinrushforth Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: missing newline at end of file

@kevinrushforth kevinrushforth requested a review from aghaisas Nov 29, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 29, 2021

@aghaisas or @arapte can one of you be the second reviewer?

arapte
arapte approved these changes Nov 30, 2021
Copy link
Member

@arapte arapte left a comment

Looks good to me. Shall re-approve when PR is updated as per Kevin's suggestion.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • fc3792d: 8276206: Rename TextBinding class to better express its purpose
  • 0dbdec4: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound
  • d14be6a: 8274061: Tree-/TableRowSkin: misbehavior on switching skin
  • 423e1be: 8277133: Dragboard contents retrieved all over again during a DND process on WebView
  • 6e6c711: 8160597: IllegalArgumentException when we initiate drag on Image
  • e694fb5: 8254956: [REDO] Memoryleak: Closed focused Stages are not collected with Monocle
  • d289db9: 8276174: JavaFX build fails on macOS aarch64
  • 27dce0a: 8276144: Update boot JDK to 17.0.1
  • 13c24d2: 8276142: Update gradle to version 7.3
  • f939d09: 8227371: Drag&Drop while holding the CMD key does not work on macOS
  • ... and 4 more: https://git.openjdk.java.net/jfx/compare/6749ab60b7673a0838d55fbd09cabf4232d5da60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 30, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 30, 2021

Looks good to me. Shall re-approve when PR is updated as per Kevin's suggestion.

@jperedadnr My suggestion was optional, so you can either integrate it as-is or make the (minor) change and we'll re-approve.

@jperedadnr
Copy link
Collaborator Author

@jperedadnr jperedadnr commented Nov 30, 2021

No problem, I just pushed the minor change.

@openjdk openjdk bot removed the ready label Nov 30, 2021
@kevinrushforth kevinrushforth requested a review from arapte Nov 30, 2021
arapte
arapte approved these changes Nov 30, 2021
@openjdk openjdk bot added the ready label Nov 30, 2021
@jperedadnr
Copy link
Collaborator Author

@jperedadnr jperedadnr commented Nov 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

Going to push as commit b257647.
Since your change was applied there have been 14 commits pushed to the master branch:

  • fc3792d: 8276206: Rename TextBinding class to better express its purpose
  • 0dbdec4: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound
  • d14be6a: 8274061: Tree-/TableRowSkin: misbehavior on switching skin
  • 423e1be: 8277133: Dragboard contents retrieved all over again during a DND process on WebView
  • 6e6c711: 8160597: IllegalArgumentException when we initiate drag on Image
  • e694fb5: 8254956: [REDO] Memoryleak: Closed focused Stages are not collected with Monocle
  • d289db9: 8276174: JavaFX build fails on macOS aarch64
  • 27dce0a: 8276144: Update boot JDK to 17.0.1
  • 13c24d2: 8276142: Update gradle to version 7.3
  • f939d09: 8227371: Drag&Drop while holding the CMD key does not work on macOS
  • ... and 4 more: https://git.openjdk.java.net/jfx/compare/6749ab60b7673a0838d55fbd09cabf4232d5da60...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@jperedadnr Pushed as commit b257647.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants