8272118: ListViewSkin et al: must not cancel edit on scrolling

[kleopatra]

Issue was that mouse pressed on the scrollbars of all virtualized controls cancelled the edit. That's inconsistent with other scroll triggers (mouseWheel, programmatic). Fixed by removing the cancel.

Added tests that failed/passed before/after the fix. Also added tests that passed both before/after to guarantee that required functionality of the mouse pressed (= requesting focus on the control if needed) is still working.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272118: ListViewSkin et al: must not cancel edit on scrolling

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/682/head:pull/682
$ git checkout pull/682

Update a local copy of the PR:
$ git checkout pull/682
$ git pull https://git.openjdk.java.net/jfx pull/682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 682

View PR using the GUI difftool:
$ git pr show -t 682

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/682.diff

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (60594fef)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[aghaisas]

Looks good to me.

[kevinrushforth]

Looks good. Thanks for adding all the tests!

[kevinrushforth]

Can you file a follow-up issue for this?

[kleopatra]

yeah, sure - was undecided whether to do it here or later (locally, there are more that will be added for fixing related issues) - JDK-8278134

[openjdk]

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272118: ListViewSkin et al: must not cancel edit on scrolling

Reviewed-by: aghaisas, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 5bd72a7: 8277457: AccessControlException: access denied ("java.net.NetPermission" "getCookieHandler")
• 3d57213: 8277475: Update JDK_DOCS property to point to JDK 17 docs
• b257647: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver
• fc3792d: 8276206: Rename TextBinding class to better express its purpose
• 0dbdec4: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

Going to push as commit aa045c5.
Since your change was applied there have been 5 commits pushed to the master branch:

• 5bd72a7: 8277457: AccessControlException: access denied ("java.net.NetPermission" "getCookieHandler")
• 3d57213: 8277475: Update JDK_DOCS property to point to JDK 17 docs
• b257647: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver
• fc3792d: 8276206: Rename TextBinding class to better express its purpose
• 0dbdec4: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound

Your commit was automatically rebased without conflicts.

[openjdk]

@kleopatra Pushed as commit aa045c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.