8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed

[kleopatra]

The misbehaviour was that an edit handler received both a commit and cancel event when cell commitEdit is called. That happened whenever a collaborator reset the controls editing state (either directly or indirectly) while processing the editCommit event. The reason was that the cell had not yet updated its own editing state when receiving the change of editing from the control.

Fix is to update cell's editing state before firing the event, that is change the sequence or method calls from fire/super.commit to super.commit/fire.

Added tests that fail/pass before/after the fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed

Reviewers

• Marius Hanl (@Maran23 - Author)
• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/684/head:pull/684
$ git checkout pull/684

Update a local copy of the PR:
$ git checkout pull/684
$ git pull https://git.openjdk.java.net/jfx pull/684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 684

View PR using the GUI difftool:
$ git pr show -t 684

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/684.diff

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (bc5a0a21)

[aghaisas]

/reviewers 2

[openjdk]

@aghaisas
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[Maran23]

Looks good to me.
I also did some manual tests and everything looks fine here too.

[aghaisas]

The fix and tests look good.

[openjdk]

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed

Reviewed-by: mhanl, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• f01c50d: Merge
• 7a1a19c: 8273998: Clarify specification for Window properties controlled by the window manager
• a4c013f: Merge
• a4e7064: Merge
• 1e3c8e9: Merge
• 145c9f3: Merge
• 9327304: Merge
• cddb953: Merge
• 155e81d: Merge
• 502ab15: Merge
• ... and 33 more: https://git.openjdk.java.net/jfx/compare/fc3792d5cb39cd3706f28953c3f97bdecc07bba6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

Going to push as commit 4c79c54.
Since your change was applied there have been 43 commits pushed to the master branch:

• f01c50d: Merge
• 7a1a19c: 8273998: Clarify specification for Window properties controlled by the window manager
• a4c013f: Merge
• a4e7064: Merge
• 1e3c8e9: Merge
• 145c9f3: Merge
• 9327304: Merge
• cddb953: Merge
• 155e81d: Merge
• 502ab15: Merge
• ... and 33 more: https://git.openjdk.java.net/jfx/compare/fc3792d5cb39cd3706f28953c3f97bdecc07bba6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kleopatra Pushed as commit 4c79c54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.