8277475: Update JDK_DOCS property to point to JDK 17 docs#686
8277475: Update JDK_DOCS property to point to JDK 17 docs#686kevinrushforth wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
johanvos
left a comment
There was a problem hiding this comment.
This works and it is a good fix.
Out of interest, I wonder if the entry in the verification-metadata matters.
I modified the sha256 value in the verification metadata to a wrong value, but it still works.
(modifying the URL for JavaSE 17 broke the process).
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This entry is the checksum of a zip bundle we use for internal builds, since our builds are done behind a firewall with no proxy set. Here is the note from the JBS Description explaining this: "I will need to also create and host a zip bundle and add its checksum to gradle/verification-metadata.xml -- see JDK-8266757 -- to avoid breaking our internal CI build." |
|
/integrate |
|
@kevinrushforth Pushed as commit 3d57213. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
We are still pointing to the JDK 12 API docs when building the JavaFX docs. This PR updates the build to point to the JDK 17 API docs.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/686/head:pull/686$ git checkout pull/686Update a local copy of the PR:
$ git checkout pull/686$ git pull https://git.openjdk.java.net/jfx pull/686/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 686View PR using the GUI difftool:
$ git pr show -t 686Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/686.diff