Skip to content

8278425: TreeTableCellStartEditTest uses deprecated TreeTableCell methods#692

Closed
Maran23 wants to merge 1 commit intoopenjdk:masterfrom
Maran23:8278425-deprecated-methods-in-tree-table-cell-start-edit-test
Closed

8278425: TreeTableCellStartEditTest uses deprecated TreeTableCell methods#692
Maran23 wants to merge 1 commit intoopenjdk:masterfrom
Maran23:8278425-deprecated-methods-in-tree-table-cell-start-edit-test

Conversation

@Maran23
Copy link
Member

@Maran23 Maran23 commented Dec 10, 2021

This PR replaces 2 deprecations which were added in https://bugs.openjdk.java.net/browse/JDK-8188026


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278425: TreeTableCellStartEditTest uses deprecated TreeTableCell methods

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/692/head:pull/692
$ git checkout pull/692

Update a local copy of the PR:
$ git checkout pull/692
$ git pull https://git.openjdk.java.net/jfx pull/692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 692

View PR using the GUI difftool:
$ git pr show -t 692

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/692.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2021

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Dec 10, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278425: TreeTableCellStartEditTest uses deprecated TreeTableCell methods

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Dec 10, 2021
@Maran23
Copy link
Member Author

Maran23 commented Dec 10, 2021

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Dec 10, 2021
@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@Maran23
Your change (at version f9a48b7) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 10, 2021

Going to push as commit 7915193.

@openjdk openjdk bot closed this Dec 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Dec 10, 2021
@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@kevinrushforth @Maran23 Pushed as commit 7915193.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Maran23 Maran23 deleted the 8278425-deprecated-methods-in-tree-table-cell-start-edit-test branch July 5, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants