8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

[paul-court]

I have an AMD Radeon VII (vega20) series GPU which is identifying with a vendor string of "AMD".

This is not present in the X11GLFactory list of preQualificationFilter vendor names, so my system (and probably any other vega20 based cards under Linux) will always fall back to software rendering.

This adds the "amd" string to the preQualificationFilter list.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8279013: ES2Pipeline fails to detect AMD vega20 graphics card

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/698/head:pull/698
$ git checkout pull/698

Update a local copy of the PR:
$ git checkout pull/698
$ git pull https://git.openjdk.java.net/jfx pull/698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 698

View PR using the GUI difftool:
$ git pr show -t 698

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/698.diff

[bridgekeeper]

Hi @Gargoyle, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user gargoyle" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[paul-court]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[paul-court]

Just as a side note, I signed the OCA last year when I was doing some work with the Helidon project. I thought it was one OCA for all things Oracle?

[kevinrushforth]

I thought it was one OCA for all things Oracle?

It is. There is a manual step to verify the connection between a user's GitHub account and their OCA, but it ordinarily happens quickly. Given that we are close to the holidays, there may be a longer delay than usual.

[paul-court]

... I signed the OCA last year ...

Added some emphasis. Hope I get a year off for Christmas next year! ;-)

/signed

[paul-court]

Hi. I'm just wondering if there is anything else I need to do for the OCA? It's been 4 weeks now, so even taking into account the holidays, I'm wondering if this request has fallen through the cracks?

Thanks

[johanvos]

I agree this would be a good and easy fix. Since there is an easy fallback to sw-rendering, this issue might impact more runtime environments than we are aware of.
@kevinrushforth is there anything we can do to check the OCA status?

[kevinrushforth]

I'll check into this.

[mlbridge]

Webrevs

• 00: Full (bec8652f)

[kevinrushforth]

Looks good to me, too.

[openjdk]

⚠️ @Gargoyle the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8279013
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@Gargoyle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279013: ES2Pipeline fails to detect AMD vega20 graphics card

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 92b10aa: Merge
• c47f18e: 8280280: Update boot JDK to 17.0.2
• 217e086: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage
• 94807b6: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases
• 4c79c54: 8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed
• f01c50d: Merge
• 7a1a19c: 8273998: Clarify specification for Window properties controlled by the window manager
• a4c013f: Merge
• a4e7064: Merge
• 1e3c8e9: Merge
• ... and 19 more: https://git.openjdk.java.net/jfx/compare/18063ade22defdf55ec1b2083a5b296422ed05f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[paul-court]

/integrate

[openjdk]

@Gargoyle
Your change (at version bec8652) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit ae334c5.
Since your change was applied there have been 29 commits pushed to the master branch:

• 92b10aa: Merge
• c47f18e: 8280280: Update boot JDK to 17.0.2
• 217e086: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage
• 94807b6: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases
• 4c79c54: 8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed
• f01c50d: Merge
• 7a1a19c: 8273998: Clarify specification for Window properties controlled by the window manager
• a4c013f: Merge
• a4e7064: Merge
• 1e3c8e9: Merge
• ... and 19 more: https://git.openjdk.java.net/jfx/compare/18063ade22defdf55ec1b2083a5b296422ed05f4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth @Gargoyle Pushed as commit ae334c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.