Skip to content

Conversation

@eduardsdv
Copy link
Contributor

@eduardsdv eduardsdv commented Dec 22, 2021

The NullPointer occurs when Accessible.getAttribute(Object) returns null.
I checked all places where the getAttribute(..) method is called. Everywhere it is checked for null (Accessible, MacAccessible, WinAccessible, WinTextRangeProvider). Only at this one place in WinAccessible.GetPatternProvider(int) it is missing.

This PR adds this missing null-check in the WinAccessible.GetPatternProvider(int) method.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8203463: [Accessibility, Narrator] NPE in TableView

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/700/head:pull/700
$ git checkout pull/700

Update a local copy of the PR:
$ git checkout pull/700
$ git pull https://git.openjdk.java.net/jfx pull/700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 700

View PR using the GUI difftool:
$ git pr show -t 700

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/700.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2021

👋 Welcome back eduardsdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Dec 22, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an obviously correct fix to me.

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@eduardsdv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8203463: [Accessibility, Narrator] NPE in TableView

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Dec 22, 2021
@eduardsdv
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@eduardsdv
Your change (at version be4d757) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

Going to push as commit c705bd4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@kevinrushforth @eduardsdv Pushed as commit c705bd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants