-
Notifications
You must be signed in to change notification settings - Fork 555
8203463: [Accessibility, Narrator] NPE in TableView #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8203463: [Accessibility, Narrator] NPE in TableView #700
Conversation
|
👋 Welcome back eduardsdv! A progress list of the required criteria for merging this PR into |
kevinrushforth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an obviously correct fix to me.
|
@eduardsdv This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@eduardsdv |
|
/sponsor |
|
Going to push as commit c705bd4. |
|
@kevinrushforth @eduardsdv Pushed as commit c705bd4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The NullPointer occurs when
Accessible.getAttribute(Object)returns null.I checked all places where the
getAttribute(..)method is called. Everywhere it is checked for null(Accessible,MacAccessible,WinAccessible,WinTextRangeProvider). Only at this one place inWinAccessible.GetPatternProvider(int)it is missing.This PR adds this missing null-check in the
WinAccessible.GetPatternProvider(int)method.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/700/head:pull/700$ git checkout pull/700Update a local copy of the PR:
$ git checkout pull/700$ git pull https://git.openjdk.java.net/jfx pull/700/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 700View PR using the GUI difftool:
$ git pr show -t 700Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/700.diff