Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView #710

Closed
wants to merge 3 commits into from

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Jan 7, 2022

This PR converts the change's from field from a list of tablePositions into a list of selected indices of rows.

It includes two tests for TableView and one for TreeTableView (the second test wasn't included due to an [issue|https://bugs.openjdk.java.net/browse/JDK-8232825] with key navigation), that pass with this PR and fail without it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/710/head:pull/710
$ git checkout pull/710

Update a local copy of the PR:
$ git checkout pull/710
$ git pull https://git.openjdk.java.net/jfx pull/710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 710

View PR using the GUI difftool:
$ git pr show -t 710

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/710.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 7, 2022

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 7, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 7, 2022

Webrevs

@kevinrushforth kevinrushforth requested a review from aghaisas Jan 11, 2022
@jperedadnr
Copy link
Collaborator Author

@jperedadnr jperedadnr commented Feb 10, 2022

After #709 was integrated, there were merge conflicts. So I needed to merge from master to fix them.

Copy link
Collaborator

@aghaisas aghaisas left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2022

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 7, 2022
@jperedadnr
Copy link
Collaborator Author

@jperedadnr jperedadnr commented Apr 7, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2022

Going to push as commit c55931f.
Since your change was applied there have been 33 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 7, 2022
@openjdk openjdk bot closed this Apr 7, 2022
@openjdk openjdk bot removed ready rfr labels Apr 7, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2022

@jperedadnr Pushed as commit c55931f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants