Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280275: JUnit5 tests using Assumptions API fail to compile in some cases #720

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 19, 2022

Fixed a test dependency issue in build.gradle that causes a compilation failure when running gradle test if the Assumptions API from JUnit5 is used. I added a test that fails to compile without the build fix and passes with the fix.

This was first discovered when testing the patch for PR #715, which fails to compile on my local macOS system. After applying this fix, I can compile and run the test from that PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280275: JUnit5 tests using Assumptions API fail to compile in some cases

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/720/head:pull/720
$ git checkout pull/720

Update a local copy of the PR:
$ git checkout pull/720
$ git pull https://git.openjdk.java.net/jfx pull/720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 720

View PR using the GUI difftool:
$ git pr show -t 720

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/720.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2022

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx18 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jan 19, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2022

Webrevs

@kevinrushforth
Copy link
Member Author

NOTE: this test fix is targeted to jfx18.

Copy link
Collaborator

@aghaisas aghaisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the test fails to compile without fix & runs successfully with the fix.

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280275: JUnit5 tests using Assumptions API fail to compile in some cases

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx18 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx18 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jan 20, 2022
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

Going to push as commit 94807b6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2022
@openjdk openjdk bot closed this Jan 20, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jan 20, 2022
@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@kevinrushforth Pushed as commit 94807b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8280275-junit5-fix branch January 20, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants