Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280951: Testbug: fix commented asserts in XXViewTest.test_rt_29650 #725

Closed
wants to merge 1 commit into from

Conversation

kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented Feb 3, 2022

the issue was commented asserts in a test methods - they had been failing due to incorrect usage of registering an edit commit handler

fix was to correct the registration and uncomment the assert (ListViewTest). For Tree/TableViewTest, had to adjust value access also (was: c&p from ListViewTest). Verified that the uncommented (corrected) asserts are failing/passing before/after fix of test bug


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280951: Testbug: fix commented asserts in XXViewTest.test_rt_29650

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/725/head:pull/725
$ git checkout pull/725

Update a local copy of the PR:
$ git checkout pull/725
$ git pull https://git.openjdk.java.net/jfx pull/725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 725

View PR using the GUI difftool:
$ git pr show -t 725

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/725.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2022

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 3, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2022

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

LGTM

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280951: Testbug: fix commented asserts in XXViewTest.test_rt_29650

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 3, 2022
@kleopatra
Copy link
Collaborator Author

kleopatra commented Feb 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit 929e7c9.

@openjdk openjdk bot added the integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready rfr labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@kleopatra Pushed as commit 929e7c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kleopatra kleopatra deleted the bug-fix-8280951 branch Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants