Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280841: Update SQLite to 3.37.2 #727

Closed

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Feb 4, 2022

Updated SQLite to 3.37.2 released on 2022-01-06 from the current version 3.32.3.

Website : https://www.sqlite.org/index.html
Source code can be found from https://www.sqlite.org/download.html at sqlite-amalgamation-3370200.zip

Verified the updated version with unit tests and sanity testing.
No issues are observed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/727/head:pull/727
$ git checkout pull/727

Update a local copy of the PR:
$ git checkout pull/727
$ git pull https://git.openjdk.java.net/jfx pull/727/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 727

View PR using the GUI difftool:
$ git pr show -t 727

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/727.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2022

👋 Welcome back HimaBinduMeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@HimaBinduMeda HimaBinduMeda changed the title Update SQLite to 3.37.2 8280841: Update SQLite to 3.37.2 Feb 7, 2022
@HimaBinduMeda HimaBinduMeda marked this pull request as ready for review February 7, 2022 10:19
@openjdk openjdk bot added the rfr Ready for review label Feb 7, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2022

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 7, 2022

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@arapte
Copy link
Member

arapte commented Feb 8, 2022

The source files match with https://www.sqlite.org/2022/sqlite-amalgamation-3370200.zip
Sanity testing looks good.
I would recommend to add UPDATING.txt to document the steps. You can refer: libxml UPDATING.txt , icu UPDATING.txt

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity testing looks good. I left one comment on UPDATING.txt.

@openjdk
Copy link

openjdk bot commented Feb 11, 2022

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280841: Update SQLite to 3.37.2

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • cdebc6c: 8281459: WebKit 613.1 build broken on M1
  • 4cf66d9: 8187309: TreeCell must not change tree's data
  • 590033f: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected
  • f326e78: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Feb 11, 2022
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Feb 11, 2022
@openjdk
Copy link

openjdk bot commented Feb 11, 2022

@HimaBinduMeda
Your change (at version 00e669a) is now ready to be sponsored by a Committer.

@arapte
Copy link
Member

arapte commented Feb 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 11, 2022

Going to push as commit 6b7b463.
Since your change was applied there have been 4 commits pushed to the master branch:

  • cdebc6c: 8281459: WebKit 613.1 build broken on M1
  • 4cf66d9: 8187309: TreeCell must not change tree's data
  • 590033f: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected
  • f326e78: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 11, 2022
@openjdk openjdk bot closed this Feb 11, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Feb 11, 2022
@openjdk
Copy link

openjdk bot commented Feb 11, 2022

@arapte @HimaBinduMeda Pushed as commit 6b7b463.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants