New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8281459: WebKit 613.1 build broken on M1 #730
Conversation
|
/reviewers 2 |
@kevinrushforth |
Thanks for the quick patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested on macOS aarch64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that this now builds fine on M1
@arapte This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Going to push as commit cdebc6c.
Your commit was automatically rebased without conflicts. |
This seems like a bad merge issue.
There were duplicate copies of four methods in
MacroAssemblerARM64.h
which caused WebKit build failure on Mac M1 machines.Just removing the methods removes the error.
With the changes in this PR, now the file
MacroAssemblerARM64.h
matches with the WebKit mainline.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/730/head:pull/730
$ git checkout pull/730
Update a local copy of the PR:
$ git checkout pull/730
$ git pull https://git.openjdk.java.net/jfx pull/730/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 730
View PR using the GUI difftool:
$ git pr show -t 730
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/730.diff