Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281711: Cherry-pick WebKit 613.1 stabilization fixes #733

Closed
wants to merge 2 commits into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Feb 16, 2022

Include additional stabilization fixes of WebKit 613.1
Sanity testing did not show any concerns.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8281711: Cherry-pick WebKit 613.1 stabilization fixes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/733/head:pull/733
$ git checkout pull/733

Update a local copy of the PR:
$ git checkout pull/733
$ git pull https://git.openjdk.java.net/jfx pull/733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 733

View PR using the GUI difftool:
$ git pr show -t 733

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/733.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2022

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 16, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2022

Webrevs

@johanvos johanvos self-requested a review February 16, 2022 08:21
@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@arapte
Copy link
Member Author

arapte commented Feb 16, 2022

/summary Stabilization fixes from WebKitGTK 2.34.5

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@arapte Setting summary to Stabilization fixes from WebKitGTK 2.34.5

@kevinrushforth
Copy link
Member

So far all my testing looks good, but I'll finish tomorrow.

@johanvos
Copy link
Collaborator

Looks good on Linux.

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281711: Cherry-pick WebKit 613.1 stabilization fixes

Stabilization fixes from WebKitGTK 2.34.5

Reviewed-by: jvos, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 17, 2022
@arapte
Copy link
Member Author

arapte commented Feb 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 18, 2022

Going to push as commit 418d343.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 18, 2022
@openjdk openjdk bot closed this Feb 18, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@arapte Pushed as commit 418d343.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the cp-613.1 branch May 10, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants