Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282100: Missed top/left bouncing for ScrollPane on Raspberry Pi with Touchscreen #736

Closed

Conversation

AlexanderScherbatiy
Copy link

@AlexanderScherbatiy AlexanderScherbatiy commented Feb 18, 2022

There is the bouncing when scrolling a node on a ScrollPane to the right/bottom (the node on the scroll pane is scrolled further than its width/height so the background is visible and then automatically is scrolled back to the node bounds) on Raspberry Pi with Touchscreen.
There is no bouncing when node is scrolled to the left/top.

The fix updates ScrollPaneSkin.updatePosX()/updatePosY() methods to not discard out of the range top/left minX/Y values in case the touch is supported.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282100: Missed top/left bouncing for ScrollPane on Raspberry Pi with Touchscreen

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/736/head:pull/736
$ git checkout pull/736

Update a local copy of the PR:
$ git checkout pull/736
$ git pull https://git.openjdk.java.net/jfx pull/736/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 736

View PR using the GUI difftool:
$ git pr show -t 736

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/736.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2022

👋 Welcome back alexsch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 18, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2022

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Feb 18, 2022

This seems like a reasonable fix. Perhaps @johanvos (or @aghaisas ) can review?

Copy link
Collaborator

@aghaisas aghaisas left a comment

The change looks correct. I verified that it does not have any side effect on non-touch devices (it is obvious from the code changes as well).

I did not test on the platform this PR is intended for.

@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@AlexanderScherbatiy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282100: Missed top/left bouncing for ScrollPane on Raspberry Pi with Touchscreen

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 263db3d: 8280020: Underline and line-through not straight in WebView
  • 2338821: 8269115: WebView paste event contains old data
  • 5112be9: 8255940: localStorage is null after window.close()
  • 2e8a4a5: 8278759: PointerEvent: buttons property set to 0 when mouse down
  • e74cbe8: 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start
  • adf1da4: 8279228: Leak in ScrollPaneSkin, related to touch events
  • 6f201f7: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)
  • a0bb545: 8281953: NullPointer in InputMethod components in JFXPanel
  • 7396396: 8282134: Certain regex can cause a JS trap in WebView

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 23, 2022
@kevinrushforth
Copy link
Member

kevinrushforth commented Mar 5, 2022

@AlexanderScherbatiy This is ready for you to integrate.

@AlexanderScherbatiy
Copy link
Author

AlexanderScherbatiy commented Mar 7, 2022

/integrate

@openjdk openjdk bot added the sponsor label Mar 7, 2022
@openjdk
Copy link

openjdk bot commented Mar 7, 2022

@AlexanderScherbatiy
Your change (at version 5347e75) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

kevinrushforth commented Mar 7, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 7, 2022

Going to push as commit ae419d7.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 263db3d: 8280020: Underline and line-through not straight in WebView
  • 2338821: 8269115: WebView paste event contains old data
  • 5112be9: 8255940: localStorage is null after window.close()
  • 2e8a4a5: 8278759: PointerEvent: buttons property set to 0 when mouse down
  • e74cbe8: 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start
  • adf1da4: 8279228: Leak in ScrollPaneSkin, related to touch events
  • 6f201f7: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)
  • a0bb545: 8281953: NullPointer in InputMethod components in JFXPanel
  • 7396396: 8282134: Certain regex can cause a JS trap in WebView

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 7, 2022
@openjdk openjdk bot closed this Mar 7, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Mar 7, 2022
@openjdk
Copy link

openjdk bot commented Mar 7, 2022

@kevinrushforth @AlexanderScherbatiy Pushed as commit ae419d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants