New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280840: Update libFFI to 3.4.2 #738
Conversation
|
/reviewers 2 |
@kevinrushforth |
Webrevs
|
[v2] - Fixed TAB issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Pending a second reviewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and tested.
@sashamatveev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Going to push as commit 1beb323.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit 1beb323. |
LibFFI updated to 3.4.2. No additional changes to our code, libffi code or build system were required. Tested on all platforms.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/738/head:pull/738
$ git checkout pull/738
Update a local copy of the PR:
$ git checkout pull/738
$ git pull https://git.openjdk.java.net/jfx pull/738/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 738
View PR using the GUI difftool:
$ git pr show -t 738
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/738.diff