8251483: TableCell: NPE on modifying item's list

[Maran23]

This PR fixes an issue where the item of the table row is null, although the cell itself is not empty (non null value).

The fix is to call indexChanged(..) immediately after the index was changed, but before all indexProperty() listener are notified.
The then notified listener in TableRowSkinBase will update the underlying cells, which will eventually result in an call to updateItem(..), where the NPE happened (and now not anymore, since the table row is now correctly setup before).

There is one special case: When the index didn't changed at all, we manually call indexChanged(..) (just like before) since when a property is not changed, invalidated() is not called, but we need to notify subclasses that updateIndex(..) was called.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8251483: TableCell: NPE on modifying item's list

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)
• Michael Strauß (@mstr2 - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/741/head:pull/741
$ git checkout pull/741

Update a local copy of the PR:
$ git checkout pull/741
$ git pull https://git.openjdk.org/jfx pull/741/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 741

View PR using the GUI difftool:
$ git pr show -t 741

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/741.diff

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (23921bf2)
• 00: Full (5f65b82c)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[aghaisas]

Looks good to me.

[mstr2]

The changed code makes sense, and fixes the issue.

[openjdk]

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8251483: TableCell: NPE on modifying item's list

Reviewed-by: aghaisas, mstrauss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• b3eca1f: 8283346: Optimize observable ArrayList creation in FXCollections
• 1f62570: 8285253: Update boot JDK to 18.0.1
• c759286: 8286774: Replace openjdk.java.net with openjdk.org
• da5bd37: 8277756: DatePicker listener might not be added when using second constructor
• 864792d: 8284654: Modal behavior returns to wrong stage
• 83a46e0: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
• f534850: 8088420: JavaFX WebView memory leak via EventListener
• d677003: 8286256: Update libxml2 to 2.9.14
• 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
• 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
• ... and 50 more: https://git.openjdk.org/jfx/compare/adf1da42de07aba5af07c67a4e756db52203256d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Maran23]

/integrate

[openjdk]

@Maran23
Your change (at version 23921bf) is now ready to be sponsored by a Committer.

[aghaisas]

/sponsor

[openjdk]

Going to push as commit 222b2b1.
Since your change was applied there have been 60 commits pushed to the master branch:

• b3eca1f: 8283346: Optimize observable ArrayList creation in FXCollections
• 1f62570: 8285253: Update boot JDK to 18.0.1
• c759286: 8286774: Replace openjdk.java.net with openjdk.org
• da5bd37: 8277756: DatePicker listener might not be added when using second constructor
• 864792d: 8284654: Modal behavior returns to wrong stage
• 83a46e0: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
• f534850: 8088420: JavaFX WebView memory leak via EventListener
• d677003: 8286256: Update libxml2 to 2.9.14
• 19a855e: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
• 18b2366: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
• ... and 50 more: https://git.openjdk.org/jfx/compare/adf1da42de07aba5af07c67a4e756db52203256d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aghaisas @Maran23 Pushed as commit 222b2b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.