New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282054: Mediaplayer not working with HTTP Live Stream link with query parameter appended with file extension m3u8 #750
Conversation
…y parameter appended with file extension m3u8
|
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested on Windows and Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on windows. lgtm.
@sashamatveev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit d1110f4.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit d1110f4. |
Note: audio will not work on Windows and Linux for stream provided in this bug report due to provided example uses separate audio stream via EXT-X-MEDIA tag and it is not supported. I filed separate issue for this.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/750/head:pull/750
$ git checkout pull/750
Update a local copy of the PR:
$ git checkout pull/750
$ git pull https://git.openjdk.java.net/jfx pull/750/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 750
View PR using the GUI difftool:
$ git pr show -t 750
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/750.diff