8283183: Skip failing PredefinedMeshManagerTest tests

[kevinrushforth]

We continue to get intermittent test failures in PredefinedMeshManagerTest due to an OOM error. See the GitHub Actions run for PR 753 for a recent failure. This test failure is tracked by JDK-8282449. Until that test bug is fixed, I propose to skip the two test methods, cylinderCacheTest and sphereCacheTest, that allocate large meshes and are prone to OOM errors.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283183: Skip failing PredefinedMeshManagerTest tests

Reviewers

• Johan Vos (@johanvos - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/754/head:pull/754
$ git checkout pull/754

Update a local copy of the PR:
$ git checkout pull/754
$ git pull https://git.openjdk.java.net/jfx pull/754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 754

View PR using the GUI difftool:
$ git pr show -t 754

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/754.diff

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (1f9066ca)

[johanvos]

I am ok with ignoring these tests.
Since these tests will typically throw an OOM exception on shared CI systems, it might be good to make the ignore conditionally -- but I'm ok with ignoring them in general as well.

[kevinrushforth]

I can't think of a good way to just skip the test on a CI system. Also, this could fail on a developer system that is either overloaded or under-provisioned (e.g., a VM with a minimal configuration).

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283183: Skip failing PredefinedMeshManagerTest tests

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 4afc8af: Merge
• df43d2b: 8282766: Create release notes for JavaFX 18

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

/integrate

[openjdk]

Going to push as commit ff75917.
Since your change was applied there have been 2 commits pushed to the master branch:

• 4afc8af: Merge
• df43d2b: 8282766: Create release notes for JavaFX 18

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth Pushed as commit ff75917.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.